Attachment 21737 Details for Bug 10890 – [SIGNED-OFF] Bug 10890 - Autobarcode "<branch>yymm00001" Fails in Acquisitions When Receiving Item

[patch] [SIGNED-OFF] Bug 10890 - Autobarcode "<branch>yymm00001" Fails in Acquisitions When Receiving Item

Bug-10890---Autobarcode-branchyymm00001-Fails-in-A.patch (text/plain), 3.06 KB, created by Srdjan Jankovic on 2013-10-03 00:56:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2013-10-03 00:56:15 UTC

Size: 3.06 KB

patch

obsolete

>From 367505f6142d7d63fbb46dfc16165f627c258deb Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 16 Sep 2013 13:29:52 +1000
>Subject: [PATCH] Bug 10890 - Autobarcode "<branch>yymm00001" Fails in
> Acquisitions When Receiving Item
>
>This patch adds the name "f" to the form that adds items when placing or receiving
>an order in Acquisitions.
>
>This is needed so that the autobarcode code (which uses document.f.field_name) will
>work properly when the system preference is set to "<branch>yymm00001".
>
>AcqCreateItem
>"placing an order"
>"receiving an order"
>
>TEST PLAN
>
>1) Set the autobarcode system preference to "<branch>yymm00001"
>2) Set the AcqCreateItem system preference to "placing an order"
>3) Plan an order
>4) Try to add a barcode to the item in the AJAX form
>5) Note that no barcode appears. Depending on your browser, you might
>receive a Javascript error popup message or a error icon at the bottom
>of your screen. You might receive no error message at all and it will
>fail seemingly silently.
>
>6) Set the AcqCreateItem system preference to "receiving an order"
>7) Receive the order
>8) Try to add a barcode to the item in the AJAX form
>9) See step 5. No barcode will appear and you might get an error message.
>
>10) Apply the patch
>11) Repeat steps 2, 3, 4, 6, 7, and 8 again. That is, try to add
>barcodes when placing an order and receiving an order.
>12) Note that a barcode now appears with the pattern of <branch>yymm00001
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt  | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>index c261530..519e8e1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
>@@ -207,7 +207,7 @@ $(document).ready(function()
>     </div>
> [% END %]
> 
>-<form action="/cgi-bin/koha/acqui/addorder.pl" method="post" id="Aform" onsubmit="return Check(this);">
>+<form action="/cgi-bin/koha/acqui/addorder.pl" method="post" id="Aform" name="f" onsubmit="return Check(this);">
> 
> <fieldset class="rows">
>         <legend>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>index 67999e4..9cae32c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
>@@ -130,7 +130,7 @@
> <h1>Receive items from : [% name %] [% IF ( invoice ) %][[% invoice %]] [% END %] (order #[% ordernumber %])</h1>
> 
> [% IF ( count ) %]
>-    <form action="/cgi-bin/koha/acqui/finishreceive.pl" method="post" onsubmit="return Check(this);">
>+    <form action="/cgi-bin/koha/acqui/finishreceive.pl" method="post" name="f" onsubmit="return Check(this);">
> <div class="yui-g">
> <div class="yui-u first">
>     <div class="error" style="display:none"></div>
>-- 
>1.8.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 10890: 21111 | 21737