Bugzilla – Attachment 21784 Details for
Bug 10419
There is no cronjob script for deleting patrons
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10419: (follow-up) tidy names of command-line switches
PASSED-QA-Bug-10419-follow-up-tidy-names-of-comman.patch (text/plain), 3.19 KB, created by
Katrin Fischer
on 2013-10-03 16:01:10 UTC
(
hide
)
Description:
[PASSED QA] Bug 10419: (follow-up) tidy names of command-line switches
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-10-03 16:01:10 UTC
Size:
3.19 KB
patch
obsolete
>From a550dd8e119096c4b8b0e44083d9746b4cf3fddb Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Tue, 6 Aug 2013 15:05:26 +0000 >Subject: [PATCH] [PASSED QA] Bug 10419: (follow-up) tidy names of > command-line switches > >[1] Use --library instead of --branchcode to be consistent > with other scripts and user-facing Koha terminology. >[2] Use --not_borrowed_since instead of --not_borrowered_since; > no need to expose typos in the API to the user. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > misc/cronjobs/delete_patrons.pl | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > >diff --git a/misc/cronjobs/delete_patrons.pl b/misc/cronjobs/delete_patrons.pl >index 36a75dd..8246146 100755 >--- a/misc/cronjobs/delete_patrons.pl >+++ b/misc/cronjobs/delete_patrons.pl >@@ -8,15 +8,15 @@ use Getopt::Long; > use C4::Members; > use Koha::DateUtils; > >-my ( $help, $verbose, $not_borrowered_since, $expired_before, $category_code, >+my ( $help, $verbose, $not_borrowed_since, $expired_before, $category_code, > $branchcode, $confirm ); > GetOptions( > 'h|help' => \$help, > 'v|verbose' => \$verbose, >- 'not_borrowered_since:s' => \$not_borrowered_since, >+ 'not_borrowed_since:s' => \$not_borrowed_since, > 'expired_before:s' => \$expired_before, > 'category_code:s' => \$category_code, >- 'branchcode:s' => \$branchcode, >+ 'library:s' => \$branchcode, > 'c|confirm' => \$confirm, > ) || pod2usage(1); > >@@ -24,20 +24,20 @@ if ($help) { > pod2usage(1); > } > >-$not_borrowered_since = dt_from_string( $not_borrowered_since, 'iso' ) >- if $not_borrowered_since; >+$not_borrowed_since = dt_from_string( $not_borrowed_since, 'iso' ) >+ if $not_borrowed_since; > > $expired_before = dt_from_string( $expired_before, 'iso' ) > if $expired_before; > >-unless ( $not_borrowered_since or $expired_before or $category_code or $branchcode ) { >+unless ( $not_borrowed_since or $expired_before or $category_code or $branchcode ) { > pod2usage(q{At least one filter is mandatory}); > exit; > } > > my $members = GetBorrowersToExpunge( > { >- not_borrowered_since => $not_borrowered_since, >+ not_borrowered_since => $not_borrowed_since, > expired_before => $expired_before, > category_code => $category_code, > branchcode => $branchcode, >@@ -74,7 +74,7 @@ delete_patrons - This script deletes patrons > > =head1 SYNOPSIS > >-delete_patrons.pl [-h -v -c] --not_borrowered_since=2013-07-21 --expired_before=2013-07-21 --category_code=CAT --branchcode=CPL >+delete_patrons.pl [-h -v -c] --not_borrowed_since=2013-07-21 --expired_before=2013-07-21 --category_code=CAT --branchcode=CPL > > dates can be generated with `date -d '-3 month' "+%Y-%m-%d"` > >@@ -88,9 +88,9 @@ Options are cumulatives. > > Print a brief help message > >-=item B<--not_borrowered_since> >+=item B<--not_borrowed_since> > >-Delete patrons who have not borrowered since this date. >+Delete patrons who have not borrowed since this date. > > =item B<--expired_date> > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10419
:
18677
|
18725
|
18743
|
18754
|
18990
|
19635
|
19651
|
20112
|
20113
|
20114
|
20115
|
20133
|
20134
|
20135
|
20136
|
20137
|
20138
|
20294
|
20295
|
20296
|
20297
|
21658
|
21765
|
21766
|
21773
|
21774
|
21780
|
21781
|
21782
|
21783
| 21784 |
21785
|
21786
|
21787