Bugzilla – Attachment 21842 Details for
Bug 10335
UNIMARC authorities search doesn't display properly information on parallel form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10335 - UNIMARC authorities search doesn't display properly information on parallel form
PASSED-QA-Bug-10335---UNIMARC-authorities-search-d.patch (text/plain), 4.03 KB, created by
Katrin Fischer
on 2013-10-07 06:47:42 UTC
(
hide
)
Description:
[PASSED QA] Bug 10335 - UNIMARC authorities search doesn't display properly information on parallel form
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-10-07 06:47:42 UTC
Size:
4.03 KB
patch
obsolete
>From b273c0a5461cf7ed47b8298c6b546d9998f24847 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Thu, 14 Mar 2013 17:25:40 +0200 >Subject: [PATCH] [PASSED QA] Bug 10335 - UNIMARC authorities search doesn't > display properly information on parallel form > >The patch corrects the issue and should not harm those who (improperly) >put only one triple in $8 > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Work as described. No koha-qa errors. >Same result on OPAC and STAFF > >Turns out that test plan is wrong, >you neet to fill tag 200ab, not 100ab, for main heading. >I filled 100a with some example data from UNIMARC auth manual. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Took me a bit to figure it out, works according to test plan. >--- > C4/AuthoritiesMarc.pm | 4 ++-- > .../en/includes/authorities-search-results.inc | 12 ++++++++++++ > .../en/includes/authorities-search-results.inc | 17 +++++++++++++++++ > 3 files changed, 31 insertions(+), 2 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 9ea3b2d..010fad7 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -979,8 +979,8 @@ sub BuildSummary { > > # Other forms > @otherscript = map { { >- lang => $_->subfield('8') || '', >- term => $_->subfield('a'), >+ lang => length ($_->subfield('8')) == 6 ? substr ($_->subfield('8'), 3, 3) : $_->subfield('8') || '', >+ term => $_->subfield('a') . ($_->subfield('b') ? ', ' . $_->subfield('b') : ''), > direction => 'ltr', > field => $_->tag, > } } $record->field('7..'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >index 366c695..2ee4571 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc >@@ -44,6 +44,14 @@ > [% END %] > </div> > [% END %] >+ [% IF summary.seefrom %] >+ <div class="authres_seefrom"> >+ [% FOREACH see IN summary.seefrom %] >+ [% PROCESS showreference heading=see.heading label="" type=see.type search='' %] >+ [% IF ! loop.last %] ; [% END %] >+ [% END %] >+ </div> >+ [% END %] > [% IF summary.seealso %] > <div class="authres_seealso"> > [% FOREACH see IN summary.seealso %] >@@ -87,6 +95,10 @@ > [% CASE ['it', 'ita'] %]Italian > [% CASE ['de', 'ger', 'deu'] %]German > [% CASE ['es', 'spa'] %]Spanish >+ [% CASE ['heb'] %]Hebrew >+ [% CASE ['ara'] %]Arabic >+ [% CASE ['gre'] %]Greek (modern) >+ [% CASE ['grc'] %]Greek (to 1453) > [% CASE %][% lang %] > [% END %] > [% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >index b113049..ea2aa16 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc >@@ -47,6 +47,14 @@ > [% END %] > </div> > [% END %] >+ [% IF summary.seefrom %] >+ <div class="authres_seefrom"> >+ [% FOREACH see IN summary.seefrom %] >+ [% PROCESS showreference heading=see.heading label="" type=see.type search='' %] >+ [% IF ! loop.last %] ; [% END %] >+ [% END %] >+ </div> >+ [% END %] > [% IF summary.seealso %] > <div class="authres_seealso"> > [% FOREACH see IN summary.seealso %] >@@ -82,3 +90,12 @@ > [% END %] > [% END %] > [% END %] >+[% BLOCK language %] >+ [% SWITCH lang %] >+ [% CASE ['heb'] %]Hebrew >+ [% CASE ['ara'] %]Arabic >+ [% CASE ['gre'] %]Greek (modern) >+ [% CASE ['grc'] %]Greek (to 1453) >+ [% CASE %][% lang %] >+ [% END %] >+[% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10335
:
18386
|
20869
| 21842 |
39258