Bugzilla – Attachment 21939 Details for
Bug 10988
Allow login via Google OAuth2 (OpenID Connect)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10988 Fix some minor typos
Bug-10988-Fix-some-minor-typos.patch (text/plain), 2.66 KB, created by
Nicholas van Oudtshoorn
on 2013-10-10 09:13:29 UTC
(
hide
)
Description:
Bug 10988 Fix some minor typos
Filename:
MIME Type:
Creator:
Nicholas van Oudtshoorn
Created:
2013-10-10 09:13:29 UTC
Size:
2.66 KB
patch
obsolete
>From 573efbb0c42fed4733d9d3380eeed195e65f6043 Mon Sep 17 00:00:00 2001 >From: Nicholas van Oudtshoorn <vanoudt@gmail.com> >Date: Thu, 10 Oct 2013 17:12:03 +0800 >Subject: [PATCH] Bug 10988 Fix some minor typos >Content-Type: text/plain; charset="utf-8" > >--- > .../intranet-tmpl/prog/en/modules/admin/preferences/admin.pref | 2 +- > opac/svc/googleoauth2 | 10 ++++------ > 2 files changed, 5 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >index 14b53e9..8d7803d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >@@ -120,7 +120,7 @@ Administration: > yes: Use > no: "Don't Use" > - Google OAuth2 login. >- - You will need to select OAuth2 when creating an app in the google cloud console, and set the web origin to your_opac_url and the redirect url to your_opac_url/cgi-bin/koha/svc/oauthlogin . >+ - You will need to select OAuth2 when creating an app in the google cloud console, and set the web origin to your_opac_url and the redirect url to your_opac_url/cgi-bin/koha/svc/googleoauth2 . > > - > - Google OAuth2 Client ID >diff --git a/opac/svc/googleoauth2 b/opac/svc/googleoauth2 >index 9df5f01..8ffef15 100755 >--- a/opac/svc/googleoauth2 >+++ b/opac/svc/googleoauth2 >@@ -1,5 +1,5 @@ > #!/bin/perl -w >-# Copyright chris@bigballofwax.co.nz 2013 >+# Copyright vanoudt@gmail.com 2013 > # > # This file is part of Koha. > # >@@ -19,7 +19,7 @@ > # > # Basic OAuth2 authentication for google goes like this > # First: get your clientid, clientsecret from google. At this stage, tell google that >-# your redirect url is /cgi-bin/koha/svc/oauthlogin >+# your redirect url is /cgi-bin/koha/svc/googleoauth2 > # > # The first thing that happens when this script is called is that one gets redirected > # to an authentication url from google >@@ -29,10 +29,8 @@ > # json id_token, which we round-trip back to google to decrypt. Finally, we can extract > # the email address from this. > # >-# There is LOTS of room for improvement here. >-# 1. move the clientid, clientsecret to systempreferences >-# 2. use the OPACBaseURL preference to compute the redirecturl >-# 4. Google recommends verifying and decrypting the id_token locally, which means caching >+# There is some room for improvement here. >+# 1. Google recommends verifying and decrypting the id_token locally, which means caching > # some information and updating it daily. But that would make things a lot faster > > use strict; >-- >1.8.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10988
:
21740
|
21936
|
21938
|
21939
|
25343
|
25570
|
25684
|
29594
|
29595
|
30014
|
30015
|
36354
|
36355
|
40087
|
40252
|
40442
|
40979
|
41663
|
43791
|
43792
|
43938
|
45667
|
45668
|
45895
|
46016
|
46473
|
46474
|
47780
|
47781
|
47782
|
49785
|
49786
|
49787