Attachment 22010 Details for Bug 11058 – Proposed Patch

[patch] Proposed Patch

0001-Bug-11058-make-variable-name-unique-within-its-scope.patch (text/plain), 1.12 KB, created by Colin Campbell on 2013-10-16 09:16:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Campbell

Created: 2013-10-16 09:16:40 UTC

Size: 1.12 KB

patch

obsolete

>From 305ebf876c1810173d10d1511b3ce393d1cb389a Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Wed, 16 Oct 2013 10:09:12 +0100
>Subject: [PATCH] Bug 11058: make variable name unique within its scope
>
>routine declares two lexical variables named $stylesheet
>rename the second to keep code clearer and
>avoid propagating compile time warnings
>---
> C4/Record.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/C4/Record.pm b/C4/Record.pm
>index 7277f2c..9d72d5a 100644
>--- a/C4/Record.pm
>+++ b/C4/Record.pm
>@@ -310,9 +310,9 @@ sub _transformWithStylesheet {
>     my $xslt = XML::LibXSLT->new();
>     my $source = $parser->parse_string($xmlrecord);
>     my $style_doc = $parser->parse_file($xslfile);
>-    my $stylesheet = $xslt->parse_stylesheet($style_doc);
>-    my $results = $stylesheet->transform($source);
>-    my $newxmlrecord = $stylesheet->output_string($results);
>+    my $style_sheet = $xslt->parse_stylesheet($style_doc);
>+    my $results = $style_sheet->transform($source);
>+    my $newxmlrecord = $style_sheet->output_string($results);
>     return ($newxmlrecord);
> }
> 
>-- 
>1.8.3.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 11058: 22010 | 22013 | 22227