Bugzilla – Attachment 22042 Details for
Bug 11077
Correct silent warnings in C4/Auth.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Remove $pki_field variable warning
0001-Bug-11077-Remove-useless-unititialized-variable-warn.patch (text/plain), 1.82 KB, created by
Tomás Cohen Arazi (tcohen)
on 2013-10-17 22:47:45 UTC
(
hide
)
Description:
Remove $pki_field variable warning
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2013-10-17 22:47:45 UTC
Size:
1.82 KB
patch
obsolete
>From 0a233442bd5a803b47e7f395fdb1d1d079cbc609 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 17 Oct 2013 15:29:00 -0700 >Subject: [PATCH] Bug 11077: Remove useless unititialized variable warning. > >During login at the Staff interface you get warnings in the logs >regarding an uninitialized value for the $pki_field variable. > >To test: >- tail -f /path/to/your-intranet-logs >- Point your browser to your staff login page >- Login >- Three warnings are showed >- Apply the patch >- Log out >- Log in >- No new warnings, and you can still log in. > >Thanks >To+ > >Sponsored-by: Universidad Nacional de Cordoba >--- > C4/Auth.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index d73edaf..4e4a82f 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -682,7 +682,8 @@ sub checkauth { > $userid = $session->param('id'); > $sessiontype = $session->param('sessiontype') || ''; > } >- if ( ( ($query->param('koha_login_context')) && ($query->param('userid') ne $session->param('id')) ) >+ if ( ( $query->param('koha_login_context') && >+ ( $query->param('userid') ne ( $session->param('id') // '' ) ) ) > || ( $cas && $query->param('ticket') ) ) { > #if a user enters an id ne to the id in the current session, we need to log them in... > #first we need to clear the anonymous session... >@@ -793,10 +794,11 @@ sub checkauth { > } > > elsif ( >+ defined $pki_field && ( > ( $pki_field eq 'Common Name' && $ENV{'SSL_CLIENT_S_DN_CN'} ) > || ( $pki_field eq 'emailAddress' > && $ENV{'SSL_CLIENT_S_DN_Email'} ) >- ) >+ ) ) > { > my $value; > if ( $pki_field eq 'Common Name' ) { >-- >1.8.3.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11077
:
22042
|
22043
|
22120
|
22125
|
22665
|
22667
|
22805
|
22806
|
22831
|
22844
|
22854
|
23197
|
23198
|
23199
|
23214
|
23215
|
23217
|
23218
|
23219
|
23240
|
23268
|
23288