Bugzilla – Attachment 22086 Details for
Bug 11034
BiblioAutoLink has incorrect return in addbiblio.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11034: remove incorrect return for BiblioAutoLink
Bug-11034-remove-incorrect-return-for-BiblioAutoLi.patch (text/plain), 1.46 KB, created by
Galen Charlton
on 2013-10-20 18:02:46 UTC
(
hide
)
Description:
Bug 11034: remove incorrect return for BiblioAutoLink
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2013-10-20 18:02:46 UTC
Size:
1.46 KB
patch
obsolete
>From 0d9d817edeab922c6290b6c296289f397a9ad807 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 10 Oct 2013 14:09:19 +0100 >Subject: [PATCH] Bug 11034: remove incorrect return for BiblioAutoLink > >BiblioAutoLink was being called expecting an array to >be returned. The subroutine in fact returns a scalar > >As the variables that the return was stored in, went >out of scope immediately. It is probably better to be >explicit that we are throwing the return away by not >going through the motions of storing it in a variable > >To test: > >[1] Add or save a bib record using the cataloging editor. >[2] Verify that no regressions have occurred >[3] (optional) If BiblioAddsAuthorities is on, verfiy that > relevant authority records are linked to. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > cataloguing/addbiblio.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index cb40396..bfb62f0 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -865,7 +865,7 @@ if ( $op eq "addbiblio" ) { > my $oldbibnum; > my $oldbibitemnum; > if (C4::Context->preference("BiblioAddsAuthorities")){ >- my ($countlinked,$countcreated)=BiblioAutoLink($record,$frameworkcode); >+ BiblioAutoLink( $record, $frameworkcode ); > } > if ( $is_a_modif ) { > ModBiblioframework( $biblionumber, $frameworkcode ); >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11034
:
21944
|
22086
|
22087
|
22313