Bugzilla – Attachment 22104 Details for
Bug 10869
Can't cancel order line if title deleted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10869 follow-up: indent & term
Bug-10869-follow-up-indent--term.patch (text/plain), 2.27 KB, created by
Paul Poulain
on 2013-10-20 19:58:46 UTC
(
hide
)
Description:
Bug 10869 follow-up: indent & term
Filename:
MIME Type:
Creator:
Paul Poulain
Created:
2013-10-20 19:58:46 UTC
Size:
2.27 KB
patch
obsolete
>From 0ea1bfb6a16025a99734bf75e128ab2a907ff55b Mon Sep 17 00:00:00 2001 >From: Paul Poulain <paul.poulain@biblibre.com> >Date: Sun, 20 Oct 2013 21:52:52 +0200 >Subject: [PATCH] Bug 10869 follow-up: indent & term > > * removing a few tabs > * fixed a few silly indents > * replaced bibnumb by biblionumber in DelOrder sub, for consistency >--- > C4/Acquisition.pm | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 42a58c4..da974d3 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1589,7 +1589,7 @@ cancelled. > =cut > > sub DelOrder { >- my ($ordernumber,$bibnum) = @_; >+ my ($ordernumber,$biblionumber) = @_; > my $dbh = C4::Context->dbh; > my $query = " > UPDATE aqorders >@@ -1599,10 +1599,10 @@ sub DelOrder { > my $sth = $dbh->prepare($query); > $sth->execute($ordernumber ); > $sth->finish; >- if ($bibnum) { >+ if ($biblionumber) { > my @itemnumbers = GetItemnumbersFromOrder( $ordernumber ); > foreach my $itemnumber (@itemnumbers){ >- C4::Items::DelItem( $dbh, $bibnum, $itemnumber ); >+ C4::Items::DelItem( $dbh, $biblionumber, $itemnumber ); > } > } > } >@@ -2023,8 +2023,8 @@ sub GetHistory { > SELECT > biblio.title, > biblio.author, >- biblioitems.isbn, >- biblioitems.ean, >+ biblioitems.isbn, >+ biblioitems.ean, > aqorders.basketno, > aqbasket.basketname, > aqbasket.basketgroupid, >@@ -2044,9 +2044,9 @@ sub GetHistory { > LEFT JOIN aqbasket ON aqorders.basketno=aqbasket.basketno > LEFT JOIN aqbasketgroups ON aqbasket.basketgroupid=aqbasketgroups.id > LEFT JOIN aqbooksellers ON aqbasket.booksellerid=aqbooksellers.id >- LEFT JOIN biblioitems ON biblioitems.biblionumber=aqorders.biblionumber >+ LEFT JOIN biblioitems ON biblioitems.biblionumber=aqorders.biblionumber > LEFT JOIN biblio ON biblio.biblionumber=aqorders.biblionumber >- LEFT JOIN aqinvoices ON aqorders.invoiceid = aqinvoices.invoiceid"; >+ LEFT JOIN aqinvoices ON aqorders.invoiceid = aqinvoices.invoiceid"; > > $query .= " LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber" > if ( C4::Context->preference("IndependentBranches") ); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10869
:
20970
|
21106
|
21294
|
21295
|
21480
|
22104
|
22299
|
22300
|
22342
|
22676
|
23839
|
24743
|
24744
|
24992
|
25000
|
25001
|
25002
|
25003
|
26692
|
26693
|
27270
|
27292
|
28516
|
29668
|
78862
|
78863
|
78864