Attachment 22195 Details for Bug 2310 – Bug 2310 - Delete grayed out w/out explanation

[patch] Bug 2310 - Delete grayed out w/out explanation

Bug-2310---Delete-grayed-out-wout-explanation.patch (text/plain), 4.38 KB, created by Owen Leonard on 2013-10-21 21:38:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-10-21 21:38:07 UTC

Size: 4.38 KB

patch

obsolete

>From f5a80ea76eae179a6f48f03f31d72108c77d54bc Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sun, 20 Oct 2013 08:12:29 -0700
>Subject: [PATCH] Bug 2310 - Delete grayed out w/out explanation
>Content-Type: text/plain; charset="utf-8"
>
>With some staff client menus options are displayed as disabled when the
>logged in user doesn't have permission to perform that function. This
>patch adds Bootstrap tooltips to patron menu items with text explaining
>why they are disabled.
>
>To test, log in as a user who lacks permission to modify patrons or set
>permissions. Open a patron record in circulation or patrons. Hovering
>over renew, delete, and set permissions links (in the patron toolbar
>"More" menu) should trigger a tooltip with a brief explanation.
>
>Test the "Update child to adult patron" link by viewing an adult patron.
>
>A separate patch will address catalog menu items.
>---
> .../intranet-tmpl/prog/en/css/staff-global.css     |    6 ++++++
> .../prog/en/includes/members-toolbar.inc           |   10 +++++-----
> 2 files changed, 11 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index aa7310c..581d59b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -2570,6 +2570,12 @@ button.closebtn{padding:0;cursor:pointer;background:transparent;border:0;-webkit
>     font-size: 13px;
> }
> 
>+.tooltip-inner {
>+    white-space:pre-wrap;
>+}
>+
>+/* End Bootstrap overrides */
>+
> .waiting {
>     cursor: wait;
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>index 787b852..60fcdad 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
>@@ -17,7 +17,7 @@ $(document).ready(function(){
>             $(".btn-group").removeClass("open");
>         });[% END %]
>     [% END %]
>-
>+    $("#updatechild, #patronflags, #renewpatron, #deletepatron").tooltip();
>     $("#exportcheckins").click(function(){
>         export_barcodes();
>         $(".btn-group").removeClass("open");
>@@ -133,22 +133,22 @@ function searchToHold(){
>                 [% IF ( CAN_user_borrowers ) %]
>                     <li><a id="renewpatron" href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% borrowernumber %]&amp;cardnumber=[% cardnumber %]&amp;destination=[% destination %]&amp;reregistration=y">Renew patron</a></li>
>                 [% ELSE %]
>-                    <li class="disabled"><a id="renewpatron" href="#">Renew patron</a></li>
>+                    <li class="disabled"><a data-toggle="tooltip" data-placement="left" title="You are not authorized to renew patrons" id="renewpatron" href="#">Renew patron</a></li>
>                 [% END %]
>                 [% IF ( CAN_user_permissions ) %]
>                     <li><a id="patronflags" href="/cgi-bin/koha/members/member-flags.pl?member=[% borrowernumber %]">Set permissions</a></li>
>                 [% ELSE %]
>-                    <li class="disabled"><a id="patronflags" href="#">Set permissions</a></li>
>+                    <li class="disabled"><a data-toggle="tooltip" data-placement="left" title="You are not authorized to set permissions" id="patronflags" href="#">Set permissions</a></li>
>                 [% END %]
>                 [% IF ( CAN_user_borrowers ) %]
>                     <li><a id="deletepatron" href="#">Delete</a></li>
>                 [% ELSE %]
>-                    <li class="disabled"><a id="deletepatron" href="#">Delete</a></li>
>+                    <li class="disabled"><a data-toggle="tooltip" data-placement="left" title="You are not authorized to delete patrons" id="deletepatron" href="#">Delete</a></li>
>                 [% END %]
>                 [% IF ( is_child ) %]
>                     <li><a id="updatechild" href="#">Update child to adult patron</a></li>
>                 [% ELSE %]
>-                    <li class="disabled"><a id="updatechild" href="#">Update child to adult patron</a></li></li>
>+                    <li class="disabled"><a data-toggle="tooltip" data-placement="left" title="Patron is an adult" id="updatechild" href="#">Update child to adult patron</a></li></li>
>                 [% END %]
>                 <li><a id="exportcheckins" href="#">Export today's checked in barcodes</a></li>
>             </ul>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 2310: 610 | 611 | 612 | 22195 | 22419 | 22456