Bugzilla – Attachment 22373 Details for
Bug 11135
Parsing of OVERRIDE_SYSPREF_NAMES logs warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-11135-Check-variable-exists-before-splitting.patch (text/plain), 1.00 KB, created by
Colin Campbell
on 2013-10-24 16:09:09 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2013-10-24 16:09:09 UTC
Size:
1.00 KB
patch
obsolete
>From 58669df4b05949559260d34f3a1c257591e7feff Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 24 Oct 2013 17:00:23 +0100 >Subject: [PATCH] Bug 11135 Check variable exists before splitting > >calling split on an undefined var generates warning to >the log. Lets check it exists before processing it >--- > admin/preferences.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index 8636afe..9a2c8ca 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -121,7 +121,10 @@ sub TransformPrefsToHTML { > my $tab = $data->{ $title }; > $tab = { '' => $tab } if ( ref( $tab ) eq 'ARRAY' ); > >- my @override_syspref_names = split( /,/, $ENV{"OVERRIDE_SYSPREF_NAMES"} ); >+ my @override_syspref_names; >+ if ( $ENV{OVERRIDE_SYSPREF_NAMES} ) { >+ @override_syspref_names = split /,/, $ENV{OVERRIDE_SYSPREF_NAMES}; >+ } > > foreach my $group ( sort keys %$tab ) { > if ( $group ) { >-- >1.8.3.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11135
:
22373
|
22632