Bugzilla – Attachment 22449 Details for
Bug 11054
Creating a child record has problems with accented Latin characters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11054: Specify utf8 encoding when creating a child record
PASSED-QA-Bug-11054-Specify-utf8-encoding-when-cre.patch (text/plain), 1.72 KB, created by
Katrin Fischer
on 2013-10-27 15:03:27 UTC
(
hide
)
Description:
[PASSED QA] Bug 11054: Specify utf8 encoding when creating a child record
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-10-27 15:03:27 UTC
Size:
1.72 KB
patch
obsolete
>From 24c56197953896524f24b95aa50a4b35569438cf Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Tue, 15 Oct 2013 15:09:08 +0100 >Subject: [PATCH] [PASSED QA] Bug 11054: Specify utf8 encoding when creating a > child record > >When the only non-ascii characters in a new child record >are latin + diacritic in the range covered by Latin-1 they >are not being added to a new child record correctly encoded. >Explicitly setting the record's encodiing ensures that >they are interpreted correctly. > >see "Unicode Bug" in perldoc perlunicode for background on >why these characters are special > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Works well. No koha-qa errors. > >Same test as before >1) with a record with diacritics in author/title, >2) press new child record, on new record 773adt >with mangled accents >3) Apply patch >4) Repeat 2, now good results > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. >Tested with a record containing umlauts in the title, >$t was empty before and umlauts in $a mangled. >After applying the patch fields are correctly filled and >diacritics display correctly. >--- > cataloguing/addbiblio.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index bfb62f0..5069af9 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -821,6 +821,7 @@ if ($hostbiblionumber) { > if ($parentbiblio) { > my $marcflavour = C4::Context->preference('marcflavour'); > $record = MARC::Record->new(); >+ SetMarcUnicodeFlag($record, $marcflavour); > my $hostfield = prepare_host_field($parentbiblio,$marcflavour); > if ($hostfield) { > $record->append_fields($hostfield); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11054
:
22005
|
22006
|
22317
|
22318
| 22449