Attachment 22454 Details for Bug 11133 – [PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML

[patch] [PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML

PASSED-QA-Bug-11133---Markup-errors-in-OPAC-place-.patch (text/plain), 2.01 KB, created by Katrin Fischer on 2013-10-27 18:56:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-10-27 18:56:14 UTC

Size: 2.01 KB

patch

obsolete

>From 6e40322afa5d2c15b32a032b0a9aed6bd155cc7d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 25 Oct 2013 10:39:03 -0400
>Subject: [PATCH] [PASSED QA] Bug 11133 - Markup errors in OPAC place hold
> form HTML
>
>There are markup errors in the OPAC place hold form which prevent it
>from validating successfully. These errors don't seem to cause any
>visual problem but can potentially cause problems when debugging
>template logic.
>
>To test, apply the patch and validate the page using your preferred
>validator (since it's a page which requires login you'll have to upload
>or paste the source). The page should validate successfully. Test when
>placing holds on:
>
>- a single item
>- multiple items
>- items which you cannot place on hold
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Passes all tests and QA script.
>Tested according to test plan and validated souce code with
>W3C Validator.
>---
> .../opac-tmpl/prog/en/modules/opac-reserve.tt      |    7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>index bf334fa..671e1f9 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
>@@ -460,8 +460,8 @@
>                                 </li>
> 
>                             [% END %]
>-                        [% END %]
>                 </ul>
>+                        [% END %]
>                   [% IF ( OPACItemHolds ) %]
>                   [% IF ( bibitemloo.holdable ) %]
> 
>@@ -540,11 +540,12 @@
>                         </table>
>                     </div>
> 
>+                </fieldset>
>+                  [% END %]
>+
>                   [% END %]
> 
>-                  [% END %]
>             </div>
>-                </fieldset>
>                 [% END %]
> 
>               [% END %] 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11133: 22411 | 22418 | 22454