Bugzilla – Attachment 22520 Details for
Bug 10770
reserve slip don't print correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
0001-Bug-10770-reserve-slip-don-t-print-correctly
0001-Bug-10770-reserve-slip-don-t-print-correctly.patch (text/plain), 6.92 KB, created by
Rafal Kopaczka
on 2013-10-29 14:05:29 UTC
(
hide
)
Description:
0001-Bug-10770-reserve-slip-don-t-print-correctly
Filename:
MIME Type:
Creator:
Rafal Kopaczka
Created:
2013-10-29 14:05:29 UTC
Size:
6.92 KB
patch
obsolete
>From cc8df97448a87a14a3ffbb40e61636e546526d64 Mon Sep 17 00:00:00 2001 >From: Rafal Kopaczka <rkk0@poczta.onet.pl> >Date: Fri, 25 Oct 2013 16:34:16 +0200 >Subject: [PATCH] Bug 10770: reserve slip don't print correctly. > When print slip is requested on hold with next available copy option, > informations about items arent populated. This patch modifies reservations > before generatig print slip. > >Test plan: >1. Place new hold on next available copy. >2. Check in any item from this hold biblio. >3. Click Print and confirm. >4. There shuld be missing itemcallnumber and barcode info. >5. Check in and print again and all informations are ok. >6. Delete hold. >7. Apply patch. >8. Repat 1-3, now at print slip there shuld be barcode and itemnumber >after first print. >--- > circ/hold-transfer-slip.pl | 3 +++ > circ/returns.pl | 2 +- > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 10 +++++----- > 3 files changed, 9 insertions(+), 6 deletions(-) > >diff --git a/circ/hold-transfer-slip.pl b/circ/hold-transfer-slip.pl >index 8ae5d2a..7adcf52 100755 >--- a/circ/hold-transfer-slip.pl >+++ b/circ/hold-transfer-slip.pl >@@ -38,6 +38,7 @@ my $session = get_session($sessionID); > > my $biblionumber = $input->param('biblionumber'); > my $borrowernumber = $input->param('borrowernumber'); >+my $itemnumber = $input->param('itemnumber'); > my $transfer = $input->param('transfer'); > > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( >@@ -52,6 +53,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > ); > > my $userenv = C4::Context->userenv; >+ >+ModReserveAffect( $itemnumber, $borrowernumber, $transfer); > my ($slip, $is_html); > if ( my $letter = ReserveSlip ($session->param('branch') || $userenv->{branch}, $borrowernumber, $biblionumber) ) { > $slip = $letter->{content}; >diff --git a/circ/returns.pl b/circ/returns.pl >index 93f36f2..137983c 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -403,7 +403,7 @@ if ( $messages->{'ResFound'}) { > barcode => $barcode, > destbranch => $reserve->{'branchcode'}, > borrowernumber => $reserve->{'borrowernumber'}, >- itemnumber => $reserve->{'itemnumber'}, >+ itemnumber => $itemnumber, > reservenotes => $reserve->{'reservenotes'}, > ); > } # else { ; } # error? >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index fb30311..e18cd98 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -108,7 +108,7 @@ $(document).ready(function () { > <input type="hidden" name="WT-waitingAt" value="[% TransferWaitingAt %]" /> > <input type="hidden" name="WT-From" value="[% wtransfertFrom %]" /> > <input type="submit" class="approve" value="Confirm" /> >- <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> >+ <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&itemnumber=[% itemnumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> > </form> > [% END %]</div> > [% END %] >@@ -144,7 +144,7 @@ $(document).ready(function () { > <form method="post" action="returns.pl" class="confirm"> > <input type="submit" class="approve" value="Confirm" /> > >- <input type="submit" value="Print and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> >+ <input type="submit" value="Print and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&itemnumber=[% itemnumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> > [% FOREACH inputloo IN inputloop %] > <input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" /> > <input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" /> >@@ -186,7 +186,7 @@ $(document).ready(function () { > > <form method="post" action="returns.pl" class="confirm"> > <input type="submit" class="approve" value="Confirm" /> >- <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> >+ <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&itemnumber=[% itemnumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> > [% FOREACH inputloo IN inputloop %] > <input type="hidden" name="ri-[% inputloo.counter %]" value="[% inputloo.barcode %]" /> > <input type="hidden" name="dd-[% inputloo.counter %]" value="[% inputloo.duedate %]" /> >@@ -294,10 +294,10 @@ $(document).ready(function () { > <form method="post" action="returns.pl" class="confirm"> > [% IF ( transfertodo ) %] > <input type="submit" class="approve" value="Confirm hold and transfer" /> >- <input type="submit" value="Print slip, transfer, and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> >+ <input type="submit" value="Print slip, transfer, and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?transfer=1&borrowernumber=[% borrowernumber %]&itemnumber=[% itemnumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> > [% ELSE %] > <input type="submit" class="approve" value="Confirm hold" /> >- <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> >+ <input type="submit" value="Print slip and confirm" class="print" onclick="Dopop('hold-transfer-slip.pl?borrowernumber=[% borrowernumber %]&itemnumber=[% itemnumber %]&biblionumber=[% itembiblionumber %]&op=slip'); this.form.submit();" /> > [% END %] > <input type="submit" class="deny" value="Ignore" onclick="$('.dialog:visible').hide('slow'); $('#barcode').focus(); return false;" /> > [% FOREACH inputloo IN inputloop %] >-- >1.7.2.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10770
: 22520