Attachment 22573 Details for Bug 11166 – Bug 11166 - branch filter in budgets admin uses pattern match instead of equals

[patch] Bug 11166 - branch filter in budgets admin uses pattern match instead of equals

0001-Bug-11166-branch-filter-in-budgets-admin-uses-patter.patch (text/plain), 1.43 KB, created by Fridolin Somers on 2013-10-30 09:48:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2013-10-30 09:48:05 UTC

Size: 1.43 KB

patch

obsolete

>From 2360e1da983c66f14303822d1e2a709976177feb Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Wed, 30 Oct 2013 10:28:49 +0100
>Subject: [PATCH] Bug 11166 - branch filter in budgets admin uses pattern match
> instead of equals
>
>In budgets administration, admin/aqbudgets.pl, there is a combobox for filtering by branch code.
>The bug is that the filter uses a pattern match  instead of equals :
>  next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/;
>In this case, if there is a branch with code '1' and one with code '12', filtering by branch '1' will also show budgets of branch '12'.
>
>Test plan :
>- Create a branch with code '1' and one with code '12'
>- Create budgets in both branches
>- Go to admin/aqbudgets.pl
>- Filter by branch '12'
>=> You see only budgets of this branch
>- Filter by branch '1'
>=> You see only budgets of this branch
>---
> admin/aqbudgets.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl
>index f7dcc75..c577c52 100755
>--- a/admin/aqbudgets.pl
>+++ b/admin/aqbudgets.pl
>@@ -296,7 +296,7 @@ if ($op eq 'add_form') {
>                   || $budget->{budget_name} =~ m/$filter_budgetname/i;
>         }
>         if ($filter_budgetbranch ) {
>-            next unless  $budget->{budget_branchcode}  =~ m/$filter_budgetbranch/;
>+            next unless  $budget->{budget_branchcode} eq $filter_budgetbranch;
>         }
> 
> ## TOTALS
>-- 
>1.8.3.2
>

Actions: View | Diff | Splinter Review

Attachments on bug 11166: 22573 | 23566 | 23724