Bugzilla – Attachment 22610 Details for
Bug 9788
Improvements for calling GetReservesFromItemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED OFF] Bug 9788: Unit tests for changed routine GetReservesFromItemnumber
SIGNED-OFF-Bug-9788-Unit-tests-for-changed-routine.patch (text/plain), 3.20 KB, created by
Mark Tompsett
on 2013-10-30 17:19:20 UTC
(
hide
)
Description:
[SIGNED OFF] Bug 9788: Unit tests for changed routine GetReservesFromItemnumber
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2013-10-30 17:19:20 UTC
Size:
3.20 KB
patch
obsolete
>From 4c5df9d1818b6853a280d4cc640dfe60a1ed71ae Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 26 Sep 2013 12:22:51 +0200 >Subject: [PATCH] [SIGNED OFF] Bug 9788: Unit tests for changed routine > GetReservesFromItemnumber > >Adds three tests to Reserves.t for GetReservesFromItemnumber. >We test if this routine does not return a future next available hold, >a future item level hold. And if it does return a future wait (that is: >a confirmed future hold, using ConfirmFutureHolds). > >Note that Holds.t does also contains some basic tests for this routine, >but the additional tests seem to better located in the direct context of >tests for bug 9761 for ConfirmFutureHolds. > >Test plan: >Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. >Verify if both tests do not fail. > >Holds.t required adding CPL branch to function. >Reserves.t does not fail for the three tests in question. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > t/db_dependent/Reserves.t | 28 +++++++++++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index ad50619..91a4709 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -2,7 +2,7 @@ > > use Modern::Perl; > >-use Test::More tests => 17; >+use Test::More tests => 20; > use MARC::Record; > use DateTime::Duration; > >@@ -266,4 +266,30 @@ is(exists $messages->{ResFound}?1:0, 1, 'AddReturn considers future reserve with > my $letter = ReserveSlip('CPL', $requesters{'CPL'}, $bibnum); > ok(defined($letter), 'can successfully generate hold slip (bug 10949)'); > >+# Tests for bug 9788: Does GetReservesFromItemnumber return a future wait? >+# 9788a: GetReservesFromItemnumber does not return future next available hold >+$dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum)); >+C4::Context->set_preference('ConfirmFutureHolds', 2); >+C4::Context->set_preference('AllowHoldDateInFuture', 1); >+$resdate= dt_from_string(); >+$resdate->add_duration(DateTime::Duration->new(days => 2)); >+$resdate=output_pref($resdate); >+AddReserve('CPL', $requesters{'CPL'}, $bibnum, >+ $constraint, $bibitems, 1, $resdate, $expdate, $notes, >+ $title, $checkitem, $found); >+my @results= GetReservesFromItemnumber($itemnumber); >+is(defined $results[3]?1:0, 0, 'GetReservesFromItemnumber does not return a future next available hold'); >+# 9788b: GetReservesFromItemnumber does not return future item level hold >+$dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum)); >+AddReserve('CPL', $requesters{'CPL'}, $bibnum, >+ $constraint, $bibitems, 1, $resdate, $expdate, $notes, >+ $title, $itemnumber, $found); #item level hold >+my @results= GetReservesFromItemnumber($itemnumber); >+is(defined $results[3]?1:0, 0, 'GetReservesFromItemnumber does not return a future item level hold'); >+# 9788c: GetReservesFromItemnumber returns future wait (confirmed future hold) >+ModReserveAffect( $itemnumber, $requesters{'CPL'} , 0); #confirm hold >+my @results= GetReservesFromItemnumber($itemnumber); >+is(defined $results[3]?1:0, 1, 'GetReservesFromItemnumber returns a future wait (confirmed future hold)'); >+# End of tests for bug 9788 >+ > $dbh->rollback; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9788
:
16026
|
16092
|
19192
|
19193
|
19194
|
19940
|
19941
|
19943
|
19944
|
21479
|
21481
|
21750
|
22309
|
22610
|
22615
|
22640
|
22641
|
22642
|
22643
|
22644
|
22645
|
22646
|
22685
|
22686
|
22687
|
22688
|
22689
|
22693
|
23931
|
23932
|
23933
|
23934
|
23935
|
23936