Bugzilla – Attachment 22637 Details for
Bug 8037
Add holds and funds to items already received in parcel.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup
Bug-8037---Add-holds-and-funds-to-items-already-re.patch (text/plain), 2.02 KB, created by
Marcel de Rooy
on 2013-10-31 13:08:44 UTC
(
hide
)
Description:
Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-10-31 13:08:44 UTC
Size:
2.02 KB
patch
obsolete
>From 8ccbae75bc1c5b62871c37e64706132f58060faf Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 22 Mar 2013 03:35:41 -0700 >Subject: [PATCH] Bug 8037 - Add holds and funds to items already received in > parcel.pl - QA Followup >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/Reserves.pm | 3 +-- > t/db_dependent/Budgets.t | 4 ++++ > 2 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 9826f2c..d1bca25 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -278,7 +278,6 @@ sub GetReservesFromBiblionumber { > my ($biblionumber) = shift or return (0, []); > my ($all_dates) = shift; > my ($itemnumber) = shift; >- warn "ITEMNUMBER: $itemnumber"; > my $dbh = C4::Context->dbh; > > # Find the desired items in the reserves >@@ -303,7 +302,7 @@ sub GetReservesFromBiblionumber { > WHERE biblionumber = ? "; > push( @params, $biblionumber ); > unless ( $all_dates ) { >- $query .= " AND reservedate <= CURRENT_DATE() "; >+ $query .= " AND reservedate <= CAST(NOW() AS DATE) "; > } > if ( $itemnumber ) { > $query .= " AND ( itemnumber IS NULL OR itemnumber = ? )"; >diff --git a/t/db_dependent/Budgets.t b/t/db_dependent/Budgets.t >index bfb910b..7c7d386 100755 >--- a/t/db_dependent/Budgets.t >+++ b/t/db_dependent/Budgets.t >@@ -92,6 +92,10 @@ ok($budget_id=AddBudget( > #| budget_owner_id | int(11) | YES | | NULL | | > #| budget_permission | int(1) | YES | | 0 | | > >+C4::Context::dbh->do('INSERT INTO aqorders ( ordernumber, budget_id ) VALUES ( 987654321, ? )', {}, ( $budget_id ) ); >+ok( GetBudgetByOrderNumber( '987654321' )->{'budget_id'} eq $budget_id, "GetBudgetByOrderNumber returns valid data" ); >+C4::Context::dbh->do('DELETE FROM aqorders WHERE ordernumber = 987654321'); >+ > my $budget; > ok($budget=GetBudget($budget_id) ,"GetBudget OK"); > $$budget{budget_permission}=1; >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8037
:
9383
|
9384
|
11089
|
13152
|
13153
|
14892
|
16336
|
16635
|
16651
|
16660
|
16749
|
18021
|
18022
|
18023
|
18693
|
19672
|
19789
|
19790
|
19791
|
22244
|
22390
|
22636
| 22637 |
22638
|
22639
|
22647