Bugzilla – Attachment 2280 Details for
Bug 4520
facets "show more" doesn't work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Revised fix based on Nahuel's patches
0001-Corrected-patch-for-Bug-4520-facets-show-more-doesn-.patch (text/plain), 4.99 KB, created by
Owen Leonard
on 2010-06-28 15:54:21 UTC
(
hide
)
Description:
Revised fix based on Nahuel's patches
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2010-06-28 15:54:21 UTC
Size:
4.99 KB
patch
obsolete
>From 3a34d44e9e1adf9790b3aab64db43fe5700b8956 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 28 Jun 2010 11:51:41 -0400 >Subject: [PATCH] Corrected patch for Bug 4520, facets "show more" doesn't work > >Re-doing Nahuel's fix so that it applies to master >--- > catalogue/search.pl | 1 + > .../intranet-tmpl/prog/en/includes/facets.inc | 2 +- > .../opac-tmpl/prog/en/includes/opac-facets.inc | 2 +- > opac/opac-search.pl | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/catalogue/search.pl b/catalogue/search.pl >index 920afb7..c33e4f7 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -543,6 +543,7 @@ for (my $i=0;$i<@servers;$i++) { > $template->param(query_cgi => $query_cgi); > $template->param(query_desc => $query_desc); > $template->param(limit_desc => $limit_desc); >+ $template->param(offset => $offset); > $template->param(DisplayMultiPlaceHold => $DisplayMultiPlaceHold); > $template->param (z3950_search_params => C4::Search::z3950_search_args($query_desc)); > if ($query_desc || $limit_desc) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index ff67047..c306c89 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -18,7 +18,7 @@ > <!-- TMPL_IF NAME="type_label_Libraries" -->Libraries<!-- /TMPL_IF --> > <ul> > <!-- TMPL_LOOP NAME="facets" --><li><a href="/cgi-bin/koha/catalogue/search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&limit=<!-- TMPL_VAR NAME="type_link_value" -->:<!-- TMPL_VAR NAME="facet_link_value" -->" title="<!-- TMPL_VAR NAME="facet_title_value" -->"><!-- TMPL_VAR NAME="facet_label_value" --></a> <!-- (<!-- TMPL_VAR NAME="facet_count" -->) --></li><!-- /TMPL_LOOP --><!-- TMPL_IF NAME="expandable" --> >- <li class="showmore"><a href="/cgi-bin/koha/catalogue/search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&expand=<!-- TMPL_VAR NAME="expand" -->#<!-- TMPL_VAR NAME="type_id" -->">Show More</a></li> >+ <li class="showmore"><a href="/cgi-bin/koha/catalogue/search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&offset=<!-- TMPL_VAR NAME="offset" -->&expand=<!-- TMPL_VAR NAME="expand" -->#<!-- TMPL_VAR NAME="type_id" -->">Show More</a></li> > <!-- /TMPL_IF --> > </ul></li> > <!-- /TMPL_LOOP --> >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >index e272906..85719f3 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >@@ -19,7 +19,7 @@ > <!-- /TMPL_UNLESS --> > <ul> > <!-- TMPL_LOOP NAME="facets" --><li><a href="/cgi-bin/koha/opac-search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&limit=<!-- TMPL_VAR NAME="type_link_value" -->:<!-- TMPL_VAR NAME="facet_link_value" -->" title="<!-- TMPL_VAR NAME="facet_title_value" ESCAPE="HTML" -->"><!-- TMPL_VAR NAME="facet_label_value" --></a> <!-- (<!-- TMPL_VAR NAME="facet_count" -->) --></li><!-- /TMPL_LOOP --><!-- TMPL_IF NAME="expandable" --> >- <li class="showmore"><a href="/cgi-bin/koha/opac-search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&expand=<!-- TMPL_VAR NAME="expand" -->#<!-- TMPL_VAR NAME="type_id" -->">Show More</a></li> >+ <li class="showmore"><a href="/cgi-bin/koha/opac-search.pl?<!-- TMPL_VAR NAME="query_cgi" --><!-- TMPL_VAR NAME="limit_cgi" --><!-- TMPL_IF NAME="sort_by" -->&sort_by=<!-- TMPL_VAR NAME="sort_by" --><!-- /TMPL_IF -->&offset=<!-- TMPL_VAR NAME="offset" -->&expand=<!-- TMPL_VAR NAME="expand" -->#<!-- TMPL_VAR NAME="type_id" -->">Show More</a></li> > <!-- /TMPL_IF --> > </ul></li> > <!-- /TMPL_LOOP --> >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index a142cb1..556e623 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -535,6 +535,7 @@ for (my $i=0;$i<=@servers;$i++) { > $template->param(query_cgi => $query_cgi); > $template->param(query_desc => $query_desc); > $template->param(limit_desc => $limit_desc); >+ $template->param(offset => $offset); > $template->param(DisplayMultiPlaceHold => $DisplayMultiPlaceHold); > if ($query_desc || $limit_desc) { > $template->param(searchdesc => 1); >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4520
: 2280