Attachment 22824 Details for Bug 11218 – Bug 11218: Due notices not being generated

[patch] Bug 11218: Due notices not being generated

Bug-11218-Due-notices-not-being-generated.patch (text/plain), 1.66 KB, created by Kyle M Hall (khall) on 2013-11-08 14:36:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-11-08 14:36:01 UTC

Size: 1.66 KB

patch

obsolete

>From c107623f780b142771ad2f279cff7244ff18136e Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Fri, 8 Nov 2013 00:31:09 +0100
>Subject: [PATCH] Bug 11218: Due notices not being generated
>
>To test:
>- Check out 2 items, due dates should be today, sometime in the past
>  and one day after tomorrow.
>- Edit the message options - activate DUE and PREDUE notices with
>  days in advance = 2
>- Run the advance_notices.pl script with -v -c
>  Result: Only a PREDUE notice is generated
>- Run the advance_notices.pl script with -v -c -m 2
>  Result: Only the PREDUE message is generated correctly.
>- Run t/db_dependent/Circulation.t
>  - without first patch: all tests pass.
>  - with first patch: some tests will fail.
>
>Apply patch.
>
>- Rerun script, now PREDUE and DUE notices should be
>  generated.
>- Run t/db_dependent/Circulation.t again, all tests should pass.
>
>Add more items with different due dates, rerun and check results.
>
>Run t/Circulation.t to confirm all tests pass.
>- Apply the patch
>
>Signed-off-by: Liz Rea <liz@catalyst.net.nz>
>Passes functional tests and automated tests.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Circulation.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 34aa358..0a22b76 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2433,7 +2433,7 @@ FROM issues
> LEFT JOIN items USING (itemnumber)
> LEFT OUTER JOIN branches USING (branchcode)
> WHERE returndate is NULL
>-HAVING days_until_due > 0 AND days_until_due < ?
>+HAVING days_until_due >= 0 AND days_until_due <= ?
> END_SQL
> 
>     my @bind_parameters = ( $params->{'days_in_advance'} );
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11218: 22795 | 22796 | 22799 | 22802 | 22803 | 22804 | 22823 | 22824 | 22825 | 27531