Bugzilla – Attachment 22845 Details for
Bug 11096
Koha cannot retrieve big records from Zebra
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11096: Take advantage of MARC::Field->as_string feature
Bug-11096-Take-advantage-of-MARCField-asstring-fea.patch (text/plain), 2.46 KB, created by
Tomás Cohen Arazi (tcohen)
on 2013-11-08 17:58:42 UTC
(
hide
)
Description:
Bug 11096: Take advantage of MARC::Field->as_string feature
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2013-11-08 17:58:42 UTC
Size:
2.46 KB
patch
obsolete
>From c70d39f1426dc2a02c43fbc136a5d1568e7a802a Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Tue, 29 Oct 2013 14:36:24 -0300 >Subject: [PATCH] Bug 11096: Take advantage of MARC::Field->as_string feature > >Avoid looping over the subfields for building the facets. pushes >higher version dependencies for MARC::File::XML and MARC::Record. > >Apply on top of the other patches for this bug, facets should >still show as usual. > >Sponsored-by: Universidad Nacional de Cordoba >--- > C4/Installer/PerlDependencies.pm | 4 ++-- > C4/Search.pm | 11 +---------- > 2 files changed, 3 insertions(+), 12 deletions(-) > >diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm >index b769c48..57ba017 100644 >--- a/C4/Installer/PerlDependencies.pm >+++ b/C4/Installer/PerlDependencies.pm >@@ -462,7 +462,7 @@ our $PERL_DEPS = { > 'MARC::Record' => { > 'usage' => 'Core', > 'required' => '1', >- 'min_ver' => '2' >+ 'min_ver' => '2.0.6' > }, > 'Locale::Currency::Format' => { > 'usage' => 'Core', >@@ -487,7 +487,7 @@ our $PERL_DEPS = { > 'MARC::File::XML' => { > 'usage' => 'Core', > 'required' => '1', >- 'min_ver' => '0.88' >+ 'min_ver' => '1.0.1' > }, > 'XML::SAX::Writer' => { > 'usage' => 'Core', >diff --git a/C4/Search.pm b/C4/Search.pm >index 5e03a70..07486f1 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -522,16 +522,7 @@ sub getRecords { > > my @fields = $marc_record->field($tag_num); > foreach my $field (@fields) { >- # TODO: Once as_string is capable of using a separator, use this >- # my $data = $field->as_string( $subfield_letters, $facet->{sep} ); >- >- my @values = (); >- foreach my $subfield (@subfields) { >- push @values, $field->subfield( $subfield ) >- if defined $field->subfield( $subfield ); >- } >- >- my $data = join( $facet->{sep}, @values ); >+ my $data = $field->as_string( $subfield_letters, $facet->{sep} ); > > unless ( $data ~~ @used_datas ) { > push @used_datas, $data; >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11096
:
22291
|
22292
|
22821
|
22845
|
22846
|
22997
|
23030
|
23033
|
23234
|
23235
|
23236
|
23237
|
23336
|
23337
|
23366
|
24019
|
24020
|
24029
|
24030
|
24031
|
24172
|
24186
|
24187
|
24188
|
24490
|
24491
|
24492
|
24580
|
24602
|
24603
|
24604
|
24605
|
24607
|
24731
|
24732
|
24874
|
24894
|
24895
|
24896
|
24901
|
25282
|
25634
|
25635
|
25636