Attachment 22891 Details for Bug 11240 – Bug 11240 : Date of restriction not saved on Patron Edit screen

[patch] Bug 11240 : Date of restriction not saved on Patron Edit screen

Bug-11240--Date-of-restriction-not-saved-on-Patron.patch (text/plain), 1.15 KB, created by Chris Cormack on 2013-11-12 22:07:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2013-11-12 22:07:39 UTC

Size: 1.15 KB

patch

obsolete

>From b146d85540e692eb30ed6b51a02ad9796a31d549 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Wed, 13 Nov 2013 11:05:32 +1300
>Subject: [PATCH] Bug 11240 : Date of restriction not saved on Patron Edit
> screen
>
>To test:
>
>1/ Edit a patron
>2/ Add a restriction with a date (in any format other than iso)
>3/ Not the date is not saved
>4/ Apply patch
>5/ Add restriction again, note it is saved
>
>The problem is output_pref was being called with the wrong parameters
>---
> members/memberentry.pl | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 4b410a7..e7f07a9 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -104,7 +104,11 @@ foreach my $d ( @debarments_to_remove ) {
> if ( $input->param('add_debarment') ) {
> 
>     my $expiration = $input->param('debarred_expiration');
>-    $expiration = $expiration ? output_pref( dt_from_string($expiration), 'iso' ) : undef;
>+    $expiration =
>+      $expiration
>+      ? output_pref(
>+        { 'dt' => dt_from_string($expiration), 'dateformat' => 'iso' } )
>+      : undef;
> 
>     AddUniqueDebarment(
>         {
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11240: 22891 | 22895 | 22947