Attachment 22894 Details for Bug 11216 – Bug 11216 - Patron modification creates indefinite manual restriction

[patch] Bug 11216 - Patron modification creates indefinite manual restriction

Bug-11216---Patron-modification-creates-indefinite.patch (text/plain), 3.44 KB, created by Jonathan Druart on 2013-11-13 08:49:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-11-13 08:49:44 UTC

Size: 3.44 KB

patch

obsolete

>From 73f3f0148f90acdf421c93395d1ba2cedb25a521 Mon Sep 17 00:00:00 2001
>From: Dobrica Pavlinusic <dpavlin@rot13.org>
>Date: Fri, 8 Nov 2013 14:50:38 +0100
>Subject: [PATCH] Bug 11216 - Patron modification creates indefinite manual
> restriction
>
>Editing partron data results in unintended adding of indefinite manual
>restriction to it. Reason for it is hidden field add_debarment which
>is wrongly initialized to 1 instead of 0. Also JavaScript code seems
>to want to toggle checkbox, and sice this field is hidden correct
>approach would be to change it's value to 1.
>
>Test scenario:
>
>1. edit patron data
>2. verify that debarrment is wrongly added
>3. remove debarrment
>3. apply this patch
>4. edit patron again
>5. verify that debarrment wasn't added
>6. intentionally add debarrment and verify that it's saved
>7. add debarment, enter something in comment but press cancel
>   and verify that debarment isn't added
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>
>This fixes this blocker, however, with or without the patch, the date
>is not saved correctly. I will file a new bug for that
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt    |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index b158556..4aa88cf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -59,7 +59,7 @@
>         });
>         $("#cancel_manual_restriction").on("click",function(e){
>             $('#debarred_expiration').val('');
>-            $('#add_debarment').prop('checked', false);
>+            $('#add_debarment').val(0);
>             $('#debarred_comment').val('');
>             mrlink.show();
>             mrform.hide();
>@@ -1221,11 +1221,11 @@
>                 [% END %]
>                     <p><a href="#" id="add_manual_restriction">Add manual restriction</a></p>
>                     <fieldset id="manual_restriction_form">
>-                        <input type="hidden" id="add_debarment" name="add_debarment" value="1" />
>+                        <input type="hidden" id="add_debarment" name="add_debarment" value="0" />
>                         <legend>Add manual restriction</legend>
>                         <ol>
>-                            <li><label for="debarred_comment">Comment: </label><input type="text" id="debarred_comment" name="debarred_comment" onchange="$('#add_debarment').prop('checked', true);" /></li>
>-                            <li><label for="debarred_expiration">Expiration: </label><input name="debarred_expiration" id="debarred_expiration" size="10" readonly="readonly" value="" class="datepicker" onchange="$('#add_debarment').prop('checked', true);" />
>+                            <li><label for="debarred_comment">Comment: </label><input type="text" id="debarred_comment" name="debarred_comment" onchange="$('#add_debarment').val(1);" /></li>
>+                            <li><label for="debarred_expiration">Expiration: </label><input name="debarred_expiration" id="debarred_expiration" size="10" readonly="readonly" value="" class="datepicker" onchange="$('#add_debarment').val(1);" />
>                                     <a href='javascript:void(0)' onclick="$('#debarred_expiration').val('');">Clear date</a></li>
> 
>                         </ol>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11216: 22819 | 22822 | 22826 | 22890 | 22894