Bugzilla – Attachment 22913 Details for
Bug 10663
Holds never block renewals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10663: (3.12.x followup) Rewrite some calls as unit tests rely on newer API
Bug-10663-312x-followup-Rewrite-some-calls-as-unit.patch (text/plain), 1.79 KB, created by
Tomás Cohen Arazi (tcohen)
on 2013-11-13 16:53:13 UTC
(
hide
)
Description:
Bug 10663: (3.12.x followup) Rewrite some calls as unit tests rely on newer API
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2013-11-13 16:53:13 UTC
Size:
1.79 KB
patch
obsolete
>From 1f9f3e25a2809bcab0f4d5f12418fc41335a3288 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 13 Nov 2013 13:41:15 -0300 >Subject: [PATCH] Bug 10663: (3.12.x followup) Rewrite some calls as unit tests > rely on newer API >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Some tests fail in t/db_dependent/Circulation.t because of API difference. >This patch is a followup for 3.12.x. > >Regards >To+ > >Sponsored-by: Universidad Nacional de Córdoba >--- > t/db_dependent/Circulation.t | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index bf27fb5..97c07bf 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -242,8 +242,7 @@ C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'"); > is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved'); > is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)'); > >- my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber}); >- CancelReserve({ reserve_id => $reserveid }); >+ CancelReserve( $biblionumber, undef, $reserving_borrowernumber ); > > > diag("Item-level hold, renewal test"); >@@ -269,8 +268,7 @@ C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'"); > > # FIXME: Add more for itemtype not for loan etc. > >- $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber}); >- CancelReserve({ reserve_id => $reserveid }); >+ CancelReserve( $biblionumber, $itemnumber, $reserving_borrowernumber ); > > diag("Too many renewals"); > >-- >1.8.4.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10663
:
19987
|
20129
|
20139
|
20140
|
20148
|
20149
|
20150
|
20151
|
20152
|
20153
|
20154
|
20155
|
20156
|
20362
|
20363
|
20364
| 22913