Bugzilla – Attachment 22941 Details for
Bug 11163
Wrong itemtype usage count when deleting an itemtype
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 11163: Wrong itemtype usage count when deleting an itemtype
SIGNED-OFF-Bug-11163-Wrong-itemtype-usage-count-wh.patch (text/plain), 1.24 KB, created by
Owen Leonard
on 2013-11-14 16:41:58 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 11163: Wrong itemtype usage count when deleting an itemtype
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-11-14 16:41:58 UTC
Size:
1.24 KB
patch
obsolete
>From 93746e29acf870fb45a8560863b509cbf34e4d74 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Tue, 29 Oct 2013 18:39:22 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 11163: Wrong itemtype usage count when > deleting an itemtype >Content-Type: text/plain; charset="utf-8" > >Wrong usage of UNION instead of UNION ALL prevented the count to match >the expected value. > >Steps to reproduce: >- Create an itemtype. >- Create some biblios setting the created itemtype at biblio level. >- Create some items setting the created itemtype on them. >- Try to delete the itemtype in Home > Administration > Item types, the >count is 1 and doesn't match the expected result. > >Regards >To+ > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > admin/itemtypes.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl >index ee70238..3c33073 100755 >--- a/admin/itemtypes.pl >+++ b/admin/itemtypes.pl >@@ -200,7 +200,7 @@ elsif ( $op eq 'delete_confirm' ) { > my $sth = $dbh->prepare(' > SELECT COUNT(*) AS total FROM ( > SELECT itemtype AS t FROM biblioitems >- UNION >+ UNION ALL > SELECT itype AS t FROM items > ) AS tmp > WHERE tmp.t=? >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11163
:
22530
|
22941
|
22954