Attachment 22959 Details for Bug 11222 – [SIGNED-OFF] Bug 11222 - A regression on label-item-search.pl done by Bug 9239

[patch] [SIGNED-OFF] Bug 11222 - A regression on label-item-search.pl done by Bug 9239

SIGNED-OFF-Bug-11222---A-regression-on-label-item-.patch (text/plain), 1.86 KB, created by Owen Leonard on 2013-11-15 13:52:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-11-15 13:52:12 UTC

Size: 1.86 KB

patch

obsolete

>From cb44a9502b09232ca0dcae31539cd269fe182eec Mon Sep 17 00:00:00 2001
>From: unknown <tajoli@tajoli-p.cilea-ad.local>
>Date: Fri, 8 Nov 2013 17:10:08 +0000
>Subject: [PATCH] [SIGNED-OFF] Bug 11222 - A regression on
> label-item-search.pl done by Bug 9239
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset="utf-8"
>
>Searching for items to add to a label batch fails with an error if
>QueryParser is enabled and you use the "Added on or before date" search
>option.
>
>Test plan:
>
>0) Set "UseQueryParser" to "do not try"
>1) Start with an installation with bibliografic data and items
>   information.
>2) Check that in items there are values inside Accession Date
>
>Without the patch:
>a) Go in Homeâº Toolsâº Labels  and click on 'New batch'
>b) Click on 'Add Item(s)'
>c) Try to select items with option "Added on or before date"
>d) You will receive an error
>
>With the patch:
>Redone points a),b), c)
>Now you don't receive an error and you can select items
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Added a description of the problem and copied the test plan from the bug
>report, with the addition of the information that QueryParser must be
>off to confirm and test.
>---
> labels/label-item-search.pl |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/labels/label-item-search.pl b/labels/label-item-search.pl
>index eeb46f8..a9a1805 100755
>--- a/labels/label-item-search.pl
>+++ b/labels/label-item-search.pl
>@@ -97,7 +97,7 @@ if ( $op eq "do_search" ) {
>             $ccl_query .= "acqdate(-" . $dateto->output("iso") . ')';
>         } else {
>             $ccl_query .= ' and ' if ( $ccl_textbox || $datefrom );
>-            $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso");
>+            $ccl_query .= "acqdate,st-date-normalized,le=" . $dateto->output("iso");
>         }
>     }
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11222: 22842 | 22959 | 23091