Bugzilla – Attachment 22986 Details for
Bug 6435
[ENH] Added daemon mode parameters to rebuild_zebra.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
QA Patch - Make daemon mode imply -z -a -b and abort on incompatible flags
0002-ENH-Bug-6435-Add-daemon-mode-QA-Patch-1a.patch (text/plain), 2.30 KB, created by
Doug Kingston
on 2013-11-17 21:20:00 UTC
(
hide
)
Description:
QA Patch - Make daemon mode imply -z -a -b and abort on incompatible flags
Filename:
MIME Type:
Creator:
Doug Kingston
Created:
2013-11-17 21:20:00 UTC
Size:
2.30 KB
patch
obsolete
>From f7f3c1a4f8d5050d45f1861a85f9e8c46b7aa2f7 Mon Sep 17 00:00:00 2001 >From: Doug Kingston <dpk@randomnotes.org> >Date: Sun, 17 Nov 2013 13:09:02 -0800 >Subject: [PATCH 2/2] ENH Bug 6435 Add daemon mode QA Patch 1a > >Based on feedback, make daemon mode imply -z -a -b and abort >on startup if flags incompatible with an incremental update daemon >are used. Update documentation to match. >--- > misc/migration_tools/rebuild_zebra.pl | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > >diff --git a/misc/migration_tools/rebuild_zebra.pl b/misc/migration_tools/rebuild_zebra.pl >index 6489fc5..1da497c 100755 >--- a/misc/migration_tools/rebuild_zebra.pl >+++ b/misc/migration_tools/rebuild_zebra.pl >@@ -115,6 +115,19 @@ if ($noshadow) { > $noshadow = ' -n '; > } > >+if ($daemon_mode) { >+ # incompatible flags handled above: help, reset, and do_not_clear_zebraqueue >+ if ($skip_export or $keep_export or $skip_index or >+ $where or $length or $offset) { >+ my $msg = "Cannot specify -s, -k, -I, -where, -length, or -offset with -daemon.\n"; >+ $msg .= "Please do '$0 --help' to see usage.\n"; >+ die $msg; >+ } >+ $authorities = 1; >+ $biblios = 1; >+ $process_zebraqueue = 1; >+} >+ > # -v is for verbose, which seems backwards here because of how logging is set > # on the CLI of zebraidx. It works this way. The default is to not log much > if ($verbose_logging >= 2) { >@@ -207,6 +220,8 @@ sub do_one_pass { > } > > # Check the zebra update queue and return true if there are records to process >+# This routine will handle each of -ab, -a, or -b, but in practice we force >+# -ab when in daemon mode. > sub zebraqueue_not_empty { > my $where_str; > >@@ -736,6 +751,11 @@ Parameters: > the zebra search index with low system overhead. > Use -sleep to control the checking interval. > >+ Daemon mode implies -z, -a, -b. The program will >+ refuse to start if options are present that do not >+ make sense while running as an incremental update >+ daemon (e.g. -r or -offset). >+ > -sleep 10 Seconds to sleep between checks of the zebraqueue > table in daemon mode. The default is 5 seconds. > >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6435
:
19267
|
19710
|
20574
|
20575
|
21097
|
21099
|
21390
|
21391
|
22039
|
22040
|
22080
|
22201
|
22457
|
22851
|
22859
| 22986