Attachment 22994 Details for Bug 11221 – [PASSED QA] Bug 11221: Follow up adding a unit test to test handling empty strings as dates

[patch] [PASSED QA] Bug 11221: Follow up adding a unit test to test handling empty strings as dates

PASSED-QA-Bug-11221-Follow-up-adding-a-unit-test-t.patch (text/plain), 1.69 KB, created by Katrin Fischer on 2013-11-18 07:46:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-11-18 07:46:24 UTC

Size: 1.69 KB

patch

obsolete

>From 43af0631f771b2ebd80e356f5465295773f4fbc6 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chris@bigballofwax.co.nz>
>Date: Sun, 17 Nov 2013 19:57:38 +1300
>Subject: [PATCH] [PASSED QA] Bug 11221: Follow up adding a unit test to test
> handling empty strings as dates
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>All tests pass.
>---
> t/db_dependent/Members.t | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t
>index 634ac0c..4cc0a3e 100755
>--- a/t/db_dependent/Members.t
>+++ b/t/db_dependent/Members.t
>@@ -6,7 +6,7 @@
> use strict;
> use warnings;
> 
>-use Test::More tests => 22;
>+use Test::More tests => 23;
> use Data::Dumper;
> 
> BEGIN {
>@@ -59,6 +59,7 @@ my %data = (
>     surname => $SURNAME,
>     categorycode => $CATEGORYCODE,
>     branchcode => $BRANCHCODE,
>+    dateofbirth => ''
> );
> 
> my $addmem=AddMember(%data);
>@@ -74,6 +75,8 @@ ok ( $member->{firstname}    eq $FIRSTNAME    &&
>      , "Got member")
>   or diag("Mismatching member details: ".Dumper(\%data, $member));
> 
>+ok($member->{dateofbirth} eq '', "Empty dates handled correctly");
>+
> $member->{firstname} = $CHANGED_FIRSTNAME;
> $member->{email}     = $EMAIL;
> $member->{ethnicity} = $ETHNICITY;
>@@ -166,7 +169,7 @@ is ($notice_email, $EMAIL, "GetNoticeEmailAddress returns correct value when Aut
> C4::Context->set_preference( 'AutoEmailPrimaryAddress', 'emailpro' );
> C4::Context->clear_syspref_cache();
> 
>-my $notice_email = GetNoticeEmailAddress($member->{'borrowernumber'});
>+$notice_email = GetNoticeEmailAddress($member->{'borrowernumber'});
> is ($notice_email, $EMAILPRO, "GetNoticeEmailAddress returns correct value when AutoEmailPrimaryAddress is emailpro");
> 
> 
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11221: 22879 | 22978 | 22979 | 22993 | 22994