Bugzilla – Attachment 23008 Details for
Bug 11269
Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search
Bug-11269---Latest-MARCRecord-makes-visible-some-w.patch (text/plain), 1.06 KB, created by
Tomás Cohen Arazi (tcohen)
on 2013-11-18 22:06:21 UTC
(
hide
)
Description:
Bug 11269 - Latest MARC::Record makes visible some wrong usage of field->subfield in C4::Search
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2013-11-18 22:06:21 UTC
Size:
1.06 KB
patch
obsolete
>From 763716363f7b2c40877c710f677aef9cd778c006 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Mon, 18 Nov 2013 19:04:56 -0300 >Subject: [PATCH] Bug 11269 - Latest MARC::Record makes visible some wrong > usage of field->subfield in C4::Search > >To test: >- Run prove -v t/db_dependent/Search.t >- There will be warnings about "Use of uninitialized value $code_wanted in string" in MARC::Field. >- Apply the patch. >- Those warnings are gone. > >Regards >To+ >--- > C4/Search.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index c9f2560..dd844e3 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1681,7 +1681,9 @@ sub searchResults { > while ( ( my $column ) = $sth2->fetchrow ) { > my ( $tagfield, $tagsubfield ) = > &GetMarcFromKohaField( "items." . $column, "" ); >- $subfieldstosearch{$column} = $tagsubfield; >+ if ( defined $tagsubfield ) { >+ $subfieldstosearch{$column} = $tagsubfield; >+ } > } > > # handle which records to actually retrieve >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11269
:
23008
|
23009