Attachment 23096 Details for Bug 11183 – Bug 11183 - Warnings in opac

[patch] Bug 11183 - Warnings in opac

Bug-11183---Warnings-in-opac.patch (text/plain), 1.33 KB, created by Kyle M Hall (khall) on 2013-11-22 17:17:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-11-22 17:17:06 UTC

Size: 1.33 KB

patch

obsolete

>From adb8be69d5c1a3ab2b826fae1ff5e2f9e64e5c56 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Sun, 10 Nov 2013 23:26:43 -0500
>Subject: [PATCH] Bug 11183 - Warnings in opac
>
>This may affect staff as well. During testing of Srdjan
>Jankovic's patch, the following error message was triggered:
>    opac-search.pl: Use of uninitialized value $code_wanted
>in string eq at /usr/share/perl5/MARC/Field.pm line 314.
>
>This was traced to a bad call on subfields in C4::Search. By
>adding an if check around the call, this warning is no longer
>triggered.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Search.pm |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index dd844e3..1afff1d 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -1842,7 +1842,9 @@ sub searchResults {
> 
>             # populate the items hash
>             foreach my $code ( keys %subfieldstosearch ) {
>-                $item->{$code} = $field->subfield( $subfieldstosearch{$code} );
>+                if ( defined( $subfieldstosearch{$code} ) ) {
>+                    $item->{$code} = $field->subfield( $subfieldstosearch{$code} );
>+                }
>             }
>             $item->{description} = $itemtypes{ $item->{itype} }{description};
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11183: 22663 | 22794 | 22801 | 22810 | 22839 | 22853 | 22855 | 22856 | 22857 | 22862 | 22866 | 22867 | 23095 | 23096 | 23097