Bugzilla – Attachment 23175 Details for
Bug 11307
Potential XSS attack vector in opac rss feed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11307 : Potential XSS attack in rss feed
PASSED-QA-Bug-11307--Potential-XSS-attack-in-rss-f.patch (text/plain), 1.54 KB, created by
Martin Renvoize (ashimema)
on 2013-11-26 17:42:19 UTC
(
hide
)
Description:
[PASSED QA] Bug 11307 : Potential XSS attack in rss feed
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2013-11-26 17:42:19 UTC
Size:
1.54 KB
patch
obsolete
>From 828cf9ee3d0573b0aec9c6d3c3408d0321665e69 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chris@bigballofwax.co.nz> >Date: Wed, 27 Nov 2013 05:37:07 +1300 >Subject: [PATCH] [PASSED QA] Bug 11307 : Potential XSS attack in rss feed > >To test: >1/ Craft a url like >/cgi-bin/koha/opac-search.pl?q=a&count=50"'<h1>test</h1>&sort_by=acqdate_dsc&format=rss2 >2/ look at the source, notice ><opensearch:itemsPerPage>50"'<h1>test</h1></opensearch:itemsPerPage> >3/ apply the patch, and reload url >4/ source now contains > <opensearch:itemsPerPage>50"'<h1>test</h1></opensearch:itemsPerPage> > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt >index 2d51ba6..ff2b23c 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-opensearch.tt >@@ -24,7 +24,7 @@ > <opensearch:totalResults>[% total %]</opensearch:totalResults> > <opensearch:startIndex>[% offset %]</opensearch:startIndex> > [% IF ( results_per_page ) %] >- <opensearch:itemsPerPage>[% results_per_page %]</opensearch:itemsPerPage> >+ <opensearch:itemsPerPage>[% results_per_page |html %]</opensearch:itemsPerPage> > [% ELSE %] > <opensearch:itemsPerPage>20</opensearch:itemsPerPage> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11307
:
23164
|
23167
|
23169
|
23170
| 23175 |
23176