Bugzilla – Attachment 23197 Details for
Bug 11077
Correct silent warnings in C4/Auth.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED_QA] Bug 11077: Uninitialized value $pki_field warning
Bug-11077-Uninitialized-value-pkifield-warning.patch (text/plain), 2.23 KB, created by
Marcel de Rooy
on 2013-11-27 17:01:16 UTC
(
hide
)
Description:
[PASSED_QA] Bug 11077: Uninitialized value $pki_field warning
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-11-27 17:01:16 UTC
Size:
2.23 KB
patch
obsolete
>From 6ce70b3b0e2319830cbc5f959e74227e7e0af901 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 17 Oct 2013 17:41:43 -0700 >Subject: [PATCH] Bug 11077: Uninitialized value $pki_field warning >Content-Type: text/plain; charset=utf-8 > >During login at the Staff interface you get warnings in the logs >regarding an uninitialized value for the $pki_field variable. > >To test: >- tail -f /path/to/your-intranet-logs >- Point your browser to your staff login page >- Login >- Three warnings are showed >- Apply the patch >- Log out >- Log in >- No new warnings, and you can still log in. > >Thanks >To+ > >Sponsored-by: Universidad Nacional de Cordoba >Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> > >Followed test plan; it works as advertised. >Also works when I deleted AllowPKIAuth system pref. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Auth.pm | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 8b0bebe..c6475bb 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -687,7 +687,7 @@ sub checkauth { > $userid = $session->param('id'); > $sessiontype = $session->param('sessiontype') || ''; > } >- if ( ( ($query->param('koha_login_context')) && ($query->param('userid') ne $session->param('id')) ) >+ if ( ( ($query->param('koha_login_context')) && ($query->param('userid') ne ($session->param('id') // '')) ) > || ( $cas && $query->param('ticket') ) ) { > #if a user enters an id ne to the id in the current session, we need to log them in... > #first we need to clear the anonymous session... >@@ -759,11 +759,12 @@ sub checkauth { > -value => $session->id, > -HttpOnly => 1 > ); >- $userid = $query->param('userid'); >+ $userid = $query->param('userid'); >+ my $pki_field = C4::Context->preference('AllowPKIAuth') // 'None'; > if ( ( $cas && $query->param('ticket') ) > || $userid >- || ( my $pki_field = C4::Context->preference('AllowPKIAuth') ) ne >- 'None' || $persona ) >+ || $pki_field ne 'None' >+ || $persona ) > { > my $password = $query->param('password'); > >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11077
:
22042
|
22043
|
22120
|
22125
|
22665
|
22667
|
22805
|
22806
|
22831
|
22844
|
22854
| 23197 |
23198
|
23199
|
23214
|
23215
|
23217
|
23218
|
23219
|
23240
|
23268
|
23288