Bugzilla – Attachment 23284 Details for
Bug 10944
Mixed content warnings in results and detail with Amazon images on https
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10944 - Followup for Bootstrap Amazon images on https OPAC
PASSED-QA-Bug-10944---Followup-for-Bootstrap-Amazo.patch (text/plain), 3.94 KB, created by
Martin Renvoize (ashimema)
on 2013-12-04 09:44:38 UTC
(
hide
)
Description:
[PASSED QA] Bug 10944 - Followup for Bootstrap Amazon images on https OPAC
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2013-12-04 09:44:38 UTC
Size:
3.94 KB
patch
obsolete
>From aa300fd16d802eb03c3ec8399380457223dd5254 Mon Sep 17 00:00:00 2001 >From: Liz Rea <liz@catalyst.net.nz> >Date: Wed, 4 Dec 2013 09:52:19 +1300 >Subject: [PATCH] [PASSED QA] Bug 10944 - Followup for Bootstrap Amazon images > on https OPAC > >see test plan for previous patch, only bootstrap theme instead of prog. :) > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 9 +++++++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++++ > 2 files changed, 11 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 867cb74..23acbc8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -46,9 +46,14 @@ > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( OPACurlOpenInNewWindow ) %] >- <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" target="_blank"><img src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >+ <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" target="_blank"> > [% ELSE %] >- <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >+ <a href="http://www.amazon[% AmazonTld %]/dp/[% normalized_isbn %]"> >+ [% END %] >+ [% IF ( using_https ) %] >+ <img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> >+ [% ELSE %] >+ <img border="0" src="http://images.amazon.com/images/P/[% normalized_isbn %].01.MZZZZZZZ.jpg" alt="Cover image" /></a> > [% END %] > [% END %] > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 2ad3029..76c89f9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -227,7 +227,11 @@ > [% END %] > [% IF ( OPACAmazonCoverImages ) %] > [% IF ( SEARCH_RESULT.normalized_isbn ) %] >+ [% IF ( using_https ) %] >+ <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="https://images-na.ssl-images-amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" /></span> >+ [% ELSE %] > <span title="[% SEARCH_RESULT.biblionumber %]" id="amazon-thumbnail[% loop.count %]"><img src="http://images.amazon.com/images/P/[% SEARCH_RESULT.normalized_isbn %].01.TZZZZZZZ.jpg" alt="" class="item-thumbnail" /></span> >+ [% END %] > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10944
:
21431
|
21839
|
21886
|
22407
|
22409
|
23280
|
23282
|
23283
|
23284
|
23285
|
24633