Bugzilla – Attachment 23311 Details for
Bug 11341
XSS attack vector in facets in OPAC - prog theme
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11341 : XSS in opac-search.pl (facets)
Bug-11341--XSS-in-opac-searchpl-facets.patch (text/plain), 2.13 KB, created by
Chris Cormack
on 2013-12-04 21:24:26 UTC
(
hide
)
Description:
Bug 11341 : XSS in opac-search.pl (facets)
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-12-04 21:24:26 UTC
Size:
2.13 KB
patch
obsolete
>From a9321f652b5ec0f8665c3b0314a00a3c7816f8a4 Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Thu, 5 Dec 2013 10:09:20 +1300 >Subject: [PATCH] Bug 11341 : XSS in opac-search.pl (facets) > >prog theme, bootstrap theme is safe > >To test >1/ Craft a url like > cgi-bin/koha/opac-search.pl?idx=kw&q=fish&offset=20" onmouseover%3dprompt(994000) bad%3d" > (the search must return enough results to have a show more link in the facets) > >2/ Check the source, or mouseover the Show more links in the facets > Notice the code is executable > >3/ Apply patch - notice it is no longer executable >--- > koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >index 04a18c6..4141896 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc >@@ -22,7 +22,7 @@ > [% IF ( facets_loo.type_label_Location ) %]Locations[% END %] > <ul> > [% FOREACH facet IN facets_loo.facets %]<li><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %]&limit=[% facet.type_link_value %]:[% facet.facet_link_value %]" title="[% facet.facet_title_value |html %]">[% facet.facet_label_value %]</a> [% IF ( displayFacetCount ) %]([% facet.facet_count %])[% END %]</li>[% END %][% IF ( facets_loo.expandable ) %] >- <li class="showmore"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %][% IF ( offset ) %]&offset=[% offset %][% END %]&expand=[% facets_loo.expand %]#[% facets_loo.type_id %]">Show more</a></li> >+ <li class="showmore"><a href="/cgi-bin/koha/opac-search.pl?[% query_cgi |html %][% limit_cgi |html %][% IF ( sort_by ) %]&sort_by=[% sort_by |html %][% END %][% IF ( offset ) %]&offset=[% offset |html %][% END %]&expand=[% facets_loo.expand %]#[% facets_loo.type_id %]">Show more</a></li> > [% END %] > </ul></li> > [% END %] >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11341
:
23311
|
23312
|
23313