Attachment 23455 Details for Bug 10983 – Bug 10983: Remove unused private subroutines from C4::Budgets

[patch] Bug 10983: Remove unused private subroutines from C4::Budgets

Bug-10983-Remove-unused-private-subroutines-from-C.patch (text/plain), 2.19 KB, created by Galen Charlton on 2013-12-11 18:21:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Galen Charlton

Created: 2013-12-11 18:21:25 UTC

Size: 2.19 KB

patch

obsolete

>From 3cd3f662e8327b6e8847da49204efdfc2149fd5a Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Wed, 2 Oct 2013 09:25:16 +0100
>Subject: [PATCH] Bug 10983: Remove unused private subroutines from
> C4::Budgets
>
>The subroutine _filter_fields is not used by the module
>and the sub _columns is only used by it
>
>This patch removes the dead code.
>
>To test:
>
>[1] Verify that the following tests pass
>
>    t/Budgets.t
>    t/Budgets/CanUserModifyBudget.t
>    t/Budgets/CanUserUseBudget.t
>    t/db_dependent/Acquisition.t
>    t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
>    t/db_dependent/Acquisition/Invoices.t
>    t/db_dependent/Acquisition/OrderFromSubscription.t
>    t/db_dependent/Acquisition/TransferOrder.t
>    t/db_dependent/Acquisition/close_reopen_basket.t
>    t/db_dependent/Bookseller.t
>    t/db_dependent/Budgets.t
>    t/db_dependent/Serials.t
>    t/db_dependent/Serials_2.t
>
>Signed-off-by: Galen Charlton <gmc@esilibrary.com>
>---
> C4/Budgets.pm |   31 -------------------------------
> 1 file changed, 31 deletions(-)
>
>diff --git a/C4/Budgets.pm b/C4/Budgets.pm
>index 334e610..758e98f 100644
>--- a/C4/Budgets.pm
>+++ b/C4/Budgets.pm
>@@ -981,37 +981,6 @@ sub ConvertCurrency {
>     return ( $price / $cur );
> }
> 
>-=head2 _columns
>-
>-returns an array containing fieldname followed by PRI as value if PRIMARY Key
>-
>-=cut
>-
>-sub _columns(;$) {
>-	my $tablename=shift||"aqbudgets";
>-    return @{C4::Context->dbh->selectcol_arrayref("SHOW columns from $tablename",{Columns=>[1,4]})};
>-}
>-
>-sub _filter_fields{
>-	my $budget=shift;
>-	my $tablename=shift;
>-    my @keys; 
>-	my @values;
>-	my %columns= _columns($tablename);
>-	#Filter Primary Keys of table
>-    my $elements=join "|",grep {$columns{$_} ne "PRI"} keys %columns;
>-	foreach my $field (grep {/\b($elements)\b/} keys %$budget){
>-		$$budget{$field}=format_date_in_iso($$budget{$field}) if ($field=~/date/ && $$budget{$field} !~C4::Dates->regexp("iso"));
>-		my $strkeys= " $field = ? ";
>-		if ($field=~/branch/){
>-			$strkeys="( $strkeys OR $field='' OR $field IS NULL) ";
>-		}
>-		push @values, $$budget{$field};
>-		push @keys, $strkeys;
>-	}
>-	return (\@keys,\@values);
>-}
>-
> END { }    # module clean-up code here (global destructor)
> 
> 1;
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10983: 21711 | 23455 | 23509