Bugzilla – Attachment 23688 Details for
Bug 7683
statistic wizard: cataloging
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7683 [Follow-up] Avoid printing useless '=1'
Bug-7683-Follow-up-Avoid-printing-useless-1.patch (text/plain), 1.64 KB, created by
Julian Maurice
on 2013-12-19 14:39:57 UTC
(
hide
)
Description:
Bug 7683 [Follow-up] Avoid printing useless '=1'
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2013-12-19 14:39:57 UTC
Size:
1.64 KB
patch
obsolete
>From 8541a06a0b24a0eba4a8273318ee68faffb7ebd5 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 22 Mar 2013 11:21:31 +0000 >Subject: [PATCH] Bug 7683 [Follow-up] Avoid printing useless '=1' > >This was caused by 'like/not like' select which had no description in >catalogue_stats.pl >--- > reports/catalogue_stats.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl >index a92a046..643497e 100755 >--- a/reports/catalogue_stats.pl >+++ b/reports/catalogue_stats.pl >@@ -234,7 +234,7 @@ sub calculate { > my @loopfilter; > for ( my $i = 0 ; $i <= @$filters ; $i++ ) { > my %cell; >- if ( defined @$filters[$i] and @$filters[$i] ne '' ) { >+ if ( defined @$filters[$i] and @$filters[$i] ne '' and $i != 16 ) { > if ( ( ( $i == 1 ) or ( $i == 3 ) or ( $i == 5 ) or ( $i == 9 ) ) and ( @$filters[ $i - 1 ] ) ) { > $cell{err} = 1 if ( @$filters[$i] < @$filters[ $i - 1 ] ); > } >@@ -256,11 +256,14 @@ sub calculate { > : ( $i == 13 ) ? "Status" > : ( $i == 14 ) ? "Materials" > : ( $i == 15 ) ? "Statistic value" >+ : ( $i == 17 and $filters->[16] == 0 ) ? "Barcode (not like)" >+ : ( $i == 17 and $filters->[16] == 1 ) ? "Barcode (like)" > : ( $i == 18 ) ? "Acquired date from" > : ( $i == 19 ) ? "Acquired date to" > : ( $i == 20 ) ? "Removed date from" > : ( $i == 21 ) ? "Removed date to" > : ''; >+ > push @loopfilter, \%cell; > } > } >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7683
:
12762
|
12785
|
12940
|
14399
|
14466
|
16327
|
16328
|
16329
|
16367
|
16775
|
20241
|
20242
|
20243
|
20244
|
20245
|
21357
|
21358
|
23683
|
23684
|
23685
|
23686
|
23687
|
23688
|
23689
|
23690
|
23691
|
25072
|
25073
|
25091
|
25092
|
25093
|
25094
|
25095
|
25096
|
25097
|
25098
|
25099
|
25100
|
26678
|
26679
|
26680
|
26681
|
26682
|
28466
|
28467
|
28468
|
28469
|
28470
|
36489
|
36490
|
36491
|
36492
|
36493
|
39129
|
39130
|
39131
|
39132
|
39133
|
41821
|
41829
|
44651
|
44652
|
44653
|
44654
|
44655
|
45238
|
45239
|
45240
|
45241
|
45242