Attachment 23719 Details for Bug 11419 – Bug 11419 - z39.50 searches not displaying errors

[patch] Bug 11419 - z39.50 searches not displaying errors

Bug-11419---z3950-searches-not-displaying-errors.patch (text/plain), 1.26 KB, created by Kyle M Hall (khall) on 2013-12-20 16:03:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-12-20 16:03:46 UTC

Size: 1.26 KB

patch

obsolete

>From f9875be41bc02d7d3ab81b2a60c1b074a2f76eb4 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 18 Dec 2013 14:44:53 -0500
>Subject: [PATCH] Bug 11419 - z39.50 searches not displaying errors
>
>When a z39.50 server isn't able to be searched successfully, the yellow
>error box comes up empty.
>
>Test Plan:
>1) Go to Administration/z39.50 servers
>2) Create a fake z39.50 server with a made up address
>3) Go to cataloging, search only that server
>4) Note the empty yellow alert box
>5) Apply this patch
>6) Re-run the search, not the alert box has a message in it now
>
>Signed-off-by: Nora Blake <nblake@masslibsystem.org>
>---
> C4/Breeding.pm |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/C4/Breeding.pm b/C4/Breeding.pm
>index 8e01d41..69adcf4 100644
>--- a/C4/Breeding.pm
>+++ b/C4/Breeding.pm
>@@ -349,7 +349,7 @@ sub Z3950Search {
>             my ($error)= $oConnection[$k]->error_x(); #ignores errmsg, addinfo, diagset
>             if ($error) {
>                 if ($error =~ m/^(10000|10007)$/ ) {
>-                    push(@errconn, { 'server' => $serverinfo[$k]->{host} } );
>+                    push(@errconn, { server => $serverinfo[$k]->{host}, error => $error } );
>                 }
>             }
>             else {
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11419: 23658 | 23719 | 23821