Bugzilla – Attachment 23780 Details for
Bug 11391
suggestions.suggesteddate has a problematic default value
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11391: (follow-up) update DBIC schema classes
Bug-11391-follow-up-update-DBIC-schema-classes.patch (text/plain), 2.08 KB, created by
Jonathan Druart
on 2013-12-23 11:04:22 UTC
(
hide
)
Description:
Bug 11391: (follow-up) update DBIC schema classes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-12-23 11:04:22 UTC
Size:
2.08 KB
patch
obsolete
>From f5898259f2dd1a02960795a8a46239fa05741318 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Fri, 13 Dec 2013 01:11:06 +0000 >Subject: [PATCH] Bug 11391: (follow-up) update DBIC schema classes > >This patch updates the DBIC schema class for Suggestion >to reflect the dropped default value for the suggesteddate >column. > >To test: > >[1] Create an empty Pg database and use the deployment script > being worked in in bug 11390. The deployment shoudl > succeed without reporting any errors regarding the > suggestions table. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > Koha/Schema/Result/Suggestion.pm | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > >diff --git a/Koha/Schema/Result/Suggestion.pm b/Koha/Schema/Result/Suggestion.pm >index 5e394fc..c1ae103 100644 >--- a/Koha/Schema/Result/Suggestion.pm >+++ b/Koha/Schema/Result/Suggestion.pm >@@ -39,7 +39,6 @@ __PACKAGE__->table("suggestions"); > > data_type: 'date' > datetime_undef_if_invalid: 1 >- default_value: '0000-00-00' > is_nullable: 0 > > =head2 managedby >@@ -215,12 +214,7 @@ __PACKAGE__->add_columns( > "suggestedby", > { data_type => "integer", default_value => 0, is_nullable => 0 }, > "suggesteddate", >- { >- data_type => "date", >- datetime_undef_if_invalid => 1, >- default_value => "0000-00-00", >- is_nullable => 0, >- }, >+ { data_type => "date", datetime_undef_if_invalid => 1, is_nullable => 0 }, > "managedby", > { data_type => "integer", is_nullable => 1 }, > "manageddate", >@@ -299,8 +293,8 @@ __PACKAGE__->add_columns( > __PACKAGE__->set_primary_key("suggestionid"); > > >-# Created by DBIx::Class::Schema::Loader v0.07025 @ 2013-10-14 20:56:21 >-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:CQRbWbu5MBouyD67ArSRNw >+# Created by DBIx::Class::Schema::Loader v0.07025 @ 2013-12-13 01:10:43 >+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:LJoqZVAeoZ0ra2BKxXRQMQ > > > # You can replace this text with custom content, and it will be preserved on regeneration >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11391
:
23498
|
23499
|
23763
|
23764
|
23779
| 23780