Attachment 23816 Details for Bug 11282 – [PASSED QA] Bug 11282 - Not possible to create multiple restrictions from patron details/new restriction overwrites existing

[patch] [PASSED QA] Bug 11282 - Not possible to create multiple restrictions from patron details/new restriction overwrites existing

PASSED-QA-Bug-11282---Not-possible-to-create-multi.patch (text/plain), 1.39 KB, created by Katrin Fischer on 2013-12-26 10:40:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-12-26 10:40:18 UTC

Size: 1.39 KB

patch

obsolete

>From 4eb4f62d5317b12f853c316818254fd8f1991517 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 22 Nov 2013 08:31:31 -0500
>Subject: [PATCH] [PASSED QA] Bug 11282 - Not possible to create multiple
> restrictions from patron details/new restriction overwrites existing
>
>Test Plan:
>1) Edit a patron, add a restriction
>2) Edit the patron again, add a second restriction
>3) Note the first restriction has disappeared!
>4) Apply this patch
>5) Edit the patron again, add another restriction
>6) Note the previous restriction is not longer removed
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Tested:
>- Adding and removing multiple restrictions from
>  - the details tab
>  - the checkouts tab
>  - the edit patron form
>All works as expected.
>Patch passes all tests in t, xt, and QA script.
>---
> members/memberentry.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index 0d3a3c3..591aa7c 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -110,7 +110,7 @@ if ( $input->param('add_debarment') ) {
>         { 'dt' => dt_from_string($expiration), 'dateformat' => 'iso' } )
>       : undef;
> 
>-    AddUniqueDebarment(
>+    AddDebarment(
>         {
>             borrowernumber => $borrowernumber,
>             type           => 'MANUAL',
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11282: 23080 | 23808 | 23816 | 23817