Attachment 23880 Details for Bug 11316 – Bug 11316 - plugin icon missing tooltip in addbiblio.pl

[patch] Bug 11316 - plugin icon missing tooltip in addbiblio.pl

Bug-11316---plugin-icon-missing-tooltip-in-addbibl.patch (text/plain), 2.60 KB, created by Biblibre Sandboxes on 2013-12-31 21:56:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2013-12-31 21:56:55 UTC

Size: 2.60 KB

patch

obsolete

>From 9311d821ce66bf059f341721c6945d8b56170bc0 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Wed, 27 Nov 2013 13:16:56 -0500
>Subject: [PATCH] Bug 11316 - plugin icon missing tooltip in addbiblio.pl
>
>By adding:
> title=\"Tag editor\"
>into the HTML generated in addbiblio, a tooltip displaying
>'Tag editor' appears when the moust is hovered over the
>plugin icon.
>
>Test Plan:
>1) Log into Staff client
>2) Click the 'Search the catalog' tab
>3) Type something which will generate results
>4) Click the title of a result
>5) Click the 'Edit' button
>6) Scroll down and click the 'Edit Record'
>7) Look through the various tabs and notice that all the plugin
> icons have no tooltip.
>8) Apply the patch
>9) Refresh the page
>10) All the plugin icons should have the tooltip text of
> 'Tag editor'.
>
>Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
>---
> cataloguing/addbiblio.pl | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index 4b1cd95..24be291 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -393,7 +393,7 @@ sub create_input {
> ($is_readonly ? "readonly=\"readonly\"" : "").
> "\/>
> <a href=\"#\" class=\"buttonDot tag_editor\"
>- onclick=\"openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."','biblio'); return false;\" tabindex=\"1\">Tag editor</a>
>+ onclick=\"openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."','biblio'); return false;\" tabindex=\"1\" title=\"Tag editor\">Tag editor</a>
> ";
> # it's a plugin field
> }
>@@ -422,7 +422,7 @@ sub create_input {
> size=\"67\"
> maxlength=\"".$subfield_data{maxlength}."\"
> onblur=\"Blur$function_name($index_tag); \" \/>
>- <a href=\"#\" class=\"buttonDot tag_editor\" onclick=\"Clic$function_name('$subfield_data{id}'); return false;\" tabindex=\"1\">Tag editor</a>
>+ <a href=\"#\" class=\"buttonDot tag_editor\" onclick=\"Clic$function_name('$subfield_data{id}'); return false;\" tabindex=\"1\" title=\"Tag editor\">Tag editor</a>
> $javascript";
> } else {
> warn "Plugin Failed: $plugin";
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11316: 23202 | 23880 | 23911