Bugzilla – Attachment 23881 Details for
Bug 11342
Error with opac self registration if BorrowersTitles is empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11342 - Error with opac self registration if BorrowersTitles is empty
Bug-11342---Error-with-opac-self-registration-if-B.patch (text/plain), 4.27 KB, created by
Biblibre Sandboxes
on 2013-12-31 22:46:58 UTC
(
hide
)
Description:
Bug 11342 - Error with opac self registration if BorrowersTitles is empty
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2013-12-31 22:46:58 UTC
Size:
4.27 KB
patch
obsolete
>From f79e072e63eb503153dea51166e275bf2fa421b0 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Dec 2013 09:13:35 -0500 >Subject: [PATCH] Bug 11342 - Error with opac self registration if BorrowersTitles is empty > >If BorrowersTitles is empty, it causes the library pulldown on the self >registration page to be empty, and to have the "Saluation" field have >the option "branches". > >This patch also fixes a minor string capitalization issue. > >Test Plan: >1) Enable OPAC self registration >2) Set the system preference BorrowersTitles to be empty >3) View the self registration page >4) Note the lack of branches in the home library pulldown >5) Apply this patch >6) Note the branches now display in the pulldown > >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> >--- > .../bootstrap/en/modules/opac-memberentry.tt | 4 ++-- > .../opac-tmpl/prog/en/modules/opac-memberentry.tt | 4 ++-- > opac/opac-memberentry.pl | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index a82380a..0d48e8d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -68,7 +68,7 @@ > [% ELSE %] > <label for="borrower_branchcode"> > [% END %] >- Home Library:</label> >+ Home library:</label> > > <select id="borrower_branchcode" name="borrower_branchcode"> > [% FOREACH b IN branches %] >@@ -100,7 +100,7 @@ > <legend id="identity_legend">Identity</legend> > > <ol> >- [% UNLESS hidden.defined('title') %] >+ [% UNLESS hidden.defined('title') || !member_titles %] > <li> > [% IF mandatory.defined('title') %] > <label for="borrower_title" class="required"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt >index 5b86268..215d8cb 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt >@@ -77,7 +77,7 @@ > [% ELSE %] > <label for="borrower_branchcode"> > [% END %] >- Home Library:</label> >+ Home library:</label> > > <select id="borrower_branchcode" name="borrower_branchcode"> > [% FOREACH b IN branches %] >@@ -107,7 +107,7 @@ > <legend id="identity_legend">Identity</legend> > > <ol> >- [% UNLESS hidden.defined('title') %] >+ [% UNLESS hidden.defined('title') || !member_titles %] > <li> > [% IF mandatory.defined('title') %] > <label for="borrower_title" class="required"> >diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl >index 9106fb4..c5c84e0 100755 >--- a/opac/opac-memberentry.pl >+++ b/opac/opac-memberentry.pl >@@ -59,7 +59,7 @@ $template->param( > action => $action, > hidden => GetHiddenFields(), > mandatory => GetMandatoryFields($action), >- member_titles => GetTitles(), >+ member_titles => GetTitles() || undef, > branches => GetBranchesLoop(), > OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), > ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11342
:
23318
|
23881
|
23910