Attachment 24153 Details for Bug 11473 – Bug 11473 - Remove boilerplate in log viewer template

[patch] Bug 11473 - Remove boilerplate in log viewer template

Bug-11473---Remove-boilerplate-in-log-viewer-templ.patch (text/plain), 4.10 KB, created by Jonathan Druart on 2014-01-10 15:47:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2014-01-10 15:47:39 UTC

Size: 4.10 KB

patch

obsolete

>From cbb494778c7c0e98b1da5b97c637d6ca4c52c758 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 6 Jan 2014 14:43:53 +1100
>Subject: [PATCH] Bug 11473 - Remove boilerplate in log viewer template
>
>This patch eliminates unnecessary conditions and boilerplate.
>
>_TEST PLAN_
>
>Apply the patch.
>
>1) Try viewing logs for circulation, patrons, fines,
>cataloguines, serials, authorities, etc.
>2) Note that everything should look exactly the same as before,
>with one exception: FINES
>3) Fines will now show "member X" for the user associated with
>the fine.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../intranet-tmpl/prog/en/modules/tools/viewlog.tt     |   16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>index ccd7cb6..a16585e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
>@@ -127,25 +127,14 @@
>                                 <tr>
>                                     <td>[% loopro.timestamp %]</td>
>                                     <td>
>-                                       [% IF ( loopro.module == 'CIRCULATION' ) %]
>-                                        <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.user %]" title="display detail for this user."> [% loopro.user %] </a>
>-                                        [% ELSE %]
>                                         <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.user %]" title="display detail for this librarian."> [% loopro.user %] </a>
>-                                        [% END %]
>                                     </td>
>                                     <td>[% loopro.module %]</td>
>                                     <td>[% loopro.action %]</td>
>                                     <td>
>-                                        [% IF ( loopro.module == 'MEMBERS' ) %]
>-                                            <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.object %]" title="Display member details."> member [% loopro.object %] </a>
>+                                        [% IF ( loopro.module == 'MEMBERS' ) || ( loopro.module == 'CIRCULATION' ) || ( loopro.module == 'FINES' ) %]
>+                                            <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.object %]" title="Display member details."> [% IF ( loopro.object ) %]member [% loopro.object %][% END %] </a>
>                                         [% ELSE %]
>-                                            [% IF ( loopro.module == 'CIRCULATION' ) %]
>-                                            <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% loopro.object %]" title="Display member details.">
>-                                                [% IF ( loopro.object ) %]
>-                                                    member [% loopro.object %]
>-                                                [% END %]
>-                                            </a>
>-                                            [% ELSE %]
>                                                 [% IF ( loopro.module == 'CATALOGUING' ) %]
>                                                     [% IF ( loopro.info.substr(0, 4) == 'item' ) %]
>                                                         <a href="/cgi-bin/koha/catalogue/moredetail.pl?item=[% loopro.object %]&amp;biblionumber=[% loopro.biblionumber %]&amp;bi=[% loopro.biblioitemnumber %]#item[% loopro.object %]">Item [% loopro.object %]</a>
>@@ -165,7 +154,6 @@
>                                                         [% END %]
>                                                     [% END %]
>                                                 [% END %]
>-                                            [% END %]
>                                         [% END %]
>                                     </td>
>                                     <td>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 11473: 23915 | 23916 | 23917 | 23918 | 23922 | 23923 | 23924 | 23925 | 24152 | 24153 | 24154 | 24155