Bugzilla – Attachment 24245 Details for
Bug 11537
Increasing test coverage for C4::Log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bug 11537: Increasing test coverage for C4::Log
bug-11537-Increasing-test-coverage-for-C4Log.patch (text/plain), 1.03 KB, created by
David Cook
on 2014-01-13 23:12:33 UTC
(
hide
)
Description:
bug 11537: Increasing test coverage for C4::Log
Filename:
MIME Type:
Creator:
David Cook
Created:
2014-01-13 23:12:33 UTC
Size:
1.03 KB
patch
obsolete
>From bfb5cf80adb256ac4ccfeb2c4ca2132967b6dfb1 Mon Sep 17 00:00:00 2001 >From: alex_h <dhorsman@xtra.co.nz> >Date: Tue, 14 Jan 2014 11:52:04 +1300 >Subject: [PATCH] bug 11537: Increasing test coverage for C4::Log > >To test: >1. run prove t/Log.t > Notice 1 test is run >2. apply patch >3. run prove t/Log.t > Notice 3 tests are run > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Works as described. > >I think there might be a typo in "Testing git log status". Should >this read "Testing get log status"? (Noticed while looking at the >code/running perl t/Log.t.) > >In any case, thanks for the patch. Looks good! >--- > t/Log.t | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > >diff --git a/t/Log.t b/t/Log.t >index eca6b9c..20b96a9 100755 >--- a/t/Log.t >+++ b/t/Log.t >@@ -6,9 +6,12 @@ > use strict; > use warnings; > >-use Test::More tests => 1; >+use Test::More tests => 3; > > BEGIN { > use_ok('C4::Log'); > } > >+ok( my $hash=GetLogStatus(),"Testing git log status"); >+ >+ok( $hash->{BorrowersLog}, 'Testing hash is non empty'); >-- >1.7.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11537
:
24243
|
24244
|
24245
|
24246
|
24268