Attachment 24268 Details for Bug 11537 – [PASSED QA] Bug 11537: Increasing test coverage for C4::Log

[patch] [PASSED QA] Bug 11537: Increasing test coverage for C4::Log

PASSED-QA-Bug-11537-Increasing-test-coverage-for-C.patch (text/plain), 1.27 KB, created by Katrin Fischer on 2014-01-14 05:55:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2014-01-14 05:55:15 UTC

Size: 1.27 KB

patch

obsolete

>From 9ef1f7e5492a27d63bfc29487e994597c9c830b1 Mon Sep 17 00:00:00 2001
>From: alex_h <dhorsman@xtra.co.nz>
>Date: Tue, 14 Jan 2014 11:52:04 +1300
>Subject: [PATCH] [PASSED QA] Bug 11537: Increasing test coverage for C4::Log
>
>To test:
>1. run prove t/Log.t
>   Notice 1 test is run
>2. apply patch
>3. run prove t/Log.t
>   Notice 3 tests are run
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>
>Works as described.
>
>I think there might be a typo in "Testing git log status". Should
>this read "Testing get log status"? (Noticed while looking at the
>code/running perl t/Log.t.)
>
>In any case, thanks for the patch. Looks good!
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Fixed typo, thanks David
>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>Works as described:
>1..3
>ok 1 - use C4::Log;
>ok 2 - Testing GetLogStatus
>ok 3 - Testing hash is non empty
>---
> t/Log.t | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/t/Log.t b/t/Log.t
>index eca6b9c..7974758 100755
>--- a/t/Log.t
>+++ b/t/Log.t
>@@ -6,9 +6,12 @@
> use strict;
> use warnings;
> 
>-use Test::More tests => 1;
>+use Test::More tests => 3;
> 
> BEGIN {
>         use_ok('C4::Log');
> }
> 
>+ok( my $hash=GetLogStatus(),"Testing GetLogStatus");
>+
>+ok( $hash->{BorrowersLog}, 'Testing hash is non empty');
>-- 
>1.8.3.2

Actions: View | Diff | Splinter Review

Attachments on bug 11537: 24243 | 24244 | 24245 | 24246 | 24268