Attachment 24269 Details for Bug 11546 – bug 11546 facets labels are not css selectable

[patch] bug 11546 facets labels are not css selectable

bug-11546-facets-labels-are-not-css-selectable.patch (text/plain), 3.33 KB, created by David Cook on 2014-01-14 06:10:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2014-01-14 06:10:49 UTC

Size: 3.33 KB

patch

obsolete

>From 9772732fdf4aad92da3fb967cf98e9cb61a8581d Mon Sep 17 00:00:00 2001
>From: Francesca Moore <francescalamoore@gmail.com>
>Date: Tue, 14 Jan 2014 14:42:38 +1300
>Subject: [PATCH] bug 11546 facets labels are not css selectable
>
>To test:
>1. search in OPAC directory
>2. inspect the facets, note that they now have spans
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>
>Works as described.
>
>I'm not sure that this change is necessary, since the parent li elements
>have IDs that can be hooked onto for CSS, but it doesn't change existing
>behaviour and more control is always nice, so that's all right.
>---
> .../bootstrap/en/includes/opac-facets.inc          |   16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>index 5669ce1..5a6f61c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>@@ -18,16 +18,16 @@
>             [% FOREACH facets_loo IN facets_loop %]
>                 [% IF facets_loo.facets.size > 0 %]
>                     <li id="[% facets_loo.type_id %]">
>-                        <h5>[% IF ( facets_loo.type_label_Authors ) %]Authors[% END %]
>-                                            [% IF ( facets_loo.type_label_Titles ) %]Titles[% END %]
>-                                            [% IF ( facets_loo.type_label_Topics ) %]Topics[% END %]
>-                                            [% IF ( facets_loo.type_label_Places ) %]Places[% END %]
>-                                            [% IF ( facets_loo.type_label_Series ) %]Series[% END %]
>-                                            [% IF ( facets_loo.type_label_ItemTypes ) %]Item types[% END %]
>+                        <h5>[% IF ( facets_loo.type_label_Authors ) %]<span id="facets-Authors">Authors</span>[% END %]
>+                                            [% IF ( facets_loo.type_label_Titles ) %]<span id="facets-Titles">Titles</span>[% END %]
>+                                            [% IF ( facets_loo.type_label_Topics ) %]<span id="facets-Topics">Topics</span>[% END %]
>+                                            [% IF ( facets_loo.type_label_Places ) %]<span id="facets-Places">Places</span>[% END %]
>+                                            [% IF ( facets_loo.type_label_Series ) %]<span id="facets-Series">Series</span>[% END %]
>+                                            [% IF ( facets_loo.type_label_ItemTypes ) %]<span id="facets-Itemtypes">Item types</span>[% END %]
>                                             [% UNLESS ( singleBranchMode ) %]
>-                                                [% IF ( facets_loo.type_label_Libraries ) %]Libraries[% END %]
>+                                                [% IF ( facets_loo.type_label_Libraries ) %]<span id="facets-Libraries">Libraries</span>[% END %]
>                                             [% END %]
>-                                            [% IF ( facets_loo.type_label_Location ) %]Locations[% END %]</h5>
>+                                            [% IF ( facets_loo.type_label_Location ) %]<span id="facets-Locations">Locations</span>[% END %]</h5>
>                         <ul>
>                             [% FOREACH facet IN facets_loo.facets %]
>                                 <li>
>-- 
>1.7.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 11546: 24256 | 24262 | 24269