Bugzilla – Attachment 24299 Details for
Bug 11541
Increasing test coverage for C4::Installer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11541 [Followup] - Increasing test coverage for C4::Installer
Bug-11541-Followup---Increasing-test-coverage-for-.patch (text/plain), 2.48 KB, created by
Kyle M Hall (khall)
on 2014-01-14 20:06:17 UTC
(
hide
)
Description:
Bug 11541 [Followup] - Increasing test coverage for C4::Installer
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2014-01-14 20:06:17 UTC
Size:
2.48 KB
patch
obsolete
>From 38ab4dbfb1abc597f93e209ed2394a1d907f8eb6 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 14 Jan 2014 15:04:27 -0500 >Subject: [PATCH] Bug 11541 [Followup] - Increasing test coverage for C4::Installer > >Tests succeed, but cause many warnings: > >prove t/Installer.t >t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in >same scope at t/Installer.t line 19. >"my" variable $self masks earlier declaration in same scope at >t/Installer.t line 20. >"my" variable $self masks earlier declaration in same scope at >t/Installer.t line 21. >"my" variable $self masks earlier declaration in same scope at >t/Installer.t line 22. >"my" variable $self masks earlier declaration in same scope at >t/Installer.t line 23. >Odd number of elements in anonymous hash at t/Installer.t line 17. >Use of uninitialized value within @ARGV in anonymous hash ({}) at >t/Installer.t line 17. > >The patch remedies that. > >Test Plan: >1) Apply first patch on this bug >2) Run "prove t/Installer.t" >3) Note the warnings >4) Apply this patch >5) Repeat step 2 >6) Note the warnings are gone >--- > t/Installer.t | 13 +++++++------ > 1 files changed, 7 insertions(+), 6 deletions(-) > >diff --git a/t/Installer.t b/t/Installer.t >index a94bdd5..cc786d8 100644 >--- a/t/Installer.t >+++ b/t/Installer.t >@@ -13,11 +13,12 @@ BEGIN { > use_ok('C4::Installer'); > } > >+my $self; > ok ( my $installer = C4::Installer->new(), 'Testing NewInstaller' ); > ok ( my $class = {shift}, 'Testing Shift' ); >-ok ( my $self->{'dbname'} = C4::Context->config("database"), 'Testing DbName' ); >-ok ( my $self->{'dbms'} = C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' ); >-ok ( my $self->{'hostname'} = C4::Context->config("hostname"), 'Testing Hostname' ); >-ok ( my $self->{'port'} = C4::Context->config("port"), 'Testing Port' ); >-ok ( my $self->{'user'} = C4::Context->config("user"), 'Testing User' ); >-ok ( my $self->{'password'} = C4::Context->config("pass"), 'Testing Password' ); >+ok ( $self->{'dbname'} = C4::Context->config("database"), 'Testing DbName' ); >+ok ( $self->{'dbms'} = C4::Context->config("db_scheme") ? C4::Context->config("db_scheme") : "mysql", 'Testing DbScheme' ); >+ok ( $self->{'hostname'} = C4::Context->config("hostname"), 'Testing Hostname' ); >+ok ( $self->{'port'} = C4::Context->config("port"), 'Testing Port' ); >+ok ( $self->{'user'} = C4::Context->config("user"), 'Testing User' ); >+ok ( $self->{'password'} = C4::Context->config("pass"), 'Testing Password' ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11541
:
24250
|
24264
|
24297
|
24299
|
24303
|
24306
|
24314
|
24315