Attachment 24493 Details for Bug 11237 – Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived

[patch] Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived

Bug-11237-Update-explanation-for-pref-AcqItemSetSu.patch (text/plain), 3.46 KB, created by Kyle M Hall (khall) on 2014-01-17 13:20:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2014-01-17 13:20:51 UTC

Size: 3.46 KB

patch

obsolete

>From 0141fcd67c37230209c40d2d7f60fa45da15e8aa Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Tue, 12 Nov 2013 10:27:17 +0100
>Subject: [PATCH] Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived
>
>Test plan:
>Update the updatedb entry and search the pref in the admin module.
>The explanation should have been updated.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> installer/data/mysql/sysprefs.sql                  |    2 +-
> installer/data/mysql/updatedatabase.pl             |   12 ++++++++++++
> .../en/modules/admin/preferences/acquisitions.pref |    2 +-
> 3 files changed, 14 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 0de3ac7..5d37379 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -1,6 +1,6 @@
> INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
> ('AcqCreateItem','ordering','ordering|receiving|cataloguing','Define when the item is created : when ordering, when receiving, or in cataloguing module','Choice'),
>-('AcqItemSetSubfieldsWhenReceived','0','','This syspref set a status for item when items are created when receiving (e.g. 995\$o=5)','Free'),
>+('AcqItemSetSubfieldsWhenReceived','0','','Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar")','Free'),
> ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'),
> ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: his own only, any within his branch or all','Choice'),
> ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 80ab210..7f706c1 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -7912,6 +7912,18 @@ if ( CheckVersion($DBversion) ) {
>     SetVersion($DBversion);
> }
> 
>+$DBversion = "3.15.00.XXX";
>+if(CheckVersion($DBversion)) {
>+    $dbh->do(q{
>+        UPDATE systempreferences
>+        SET explanation = 'Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar")'
>+        WHERE variable = "AcqItemSetSubfieldsWhenReceived"
>+    });
>+    print "Upgrade to $DBversion done (Bug 11237: Update explanation for AcqItemSetSubfieldsWhenReceived syspref)\n";
>+    SetVersion($DBversion);
>+}
>+
>+
> =head1 FUNCTIONS
> 
> =head2 TableExists($table)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>index 5eba790..60ba8be 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>@@ -43,8 +43,8 @@ Acquisitions:
>                   no: "Do not warn"
>             - when the librarian tries to create an invoice with a duplicate number.
>         -
>+            - Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar").
>             - pref: AcqItemSetSubfieldsWhenReceived
>-            - Set subfields for item when items are created when receiving (e.g. o=5|a="foo bar")
> 
>     Printing:
>         -
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 11237: 22868 | 24376 | 24410 | 24451 | 24469 | 24493 | 24494