Bugzilla – Attachment 24549 Details for
Bug 11549
After transferring an order, receive and cancel the receipt will delete the order
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber
PASSED-QA-Bug-11549-follow-up-Make-NewOrder-calcul.patch (text/plain), 1.37 KB, created by
Katrin Fischer
on 2014-01-18 20:09:46 UTC
(
hide
)
Description:
[PASSED QA] Bug 11549: [follow-up] Make NewOrder calculate new parent_ordernumber
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-01-18 20:09:46 UTC
Size:
1.37 KB
patch
obsolete
>From 935923fcb9a150c63cff27425e742f4145c82ef6 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 17 Jan 2014 11:21:05 +0100 >Subject: [PATCH] [PASSED QA] Bug 11549: [follow-up] Make NewOrder calculate > new parent_ordernumber > >If parent_ordernumber is not set in NewOrder parameter, it is >automatically set to ordernumber. >This patch only avoid code duplication. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >This solution is better! > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. Also all tests in >t/db_dependent/Acquisitions/. > >Confirmed bug and that the patch fixes it. >--- > C4/Acquisition.pm | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 67ea46e..56c2d7f 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1814,16 +1814,11 @@ sub TransferOrder { > $rv = $sth->execute($ordernumber); > > delete $order->{'ordernumber'}; >+ delete $order->{parent_ordernumber}; > $order->{'basketno'} = $basketno; > my $newordernumber; > (undef, $newordernumber) = NewOrder($order); > >- $dbh->do( q{ >- UPDATE aqorders >- SET parent_ordernumber = ordernumber >- WHERE ordernumber = ? >- }, {}, $newordernumber ); >- > $query = q{ > UPDATE aqorders_items > SET ordernumber = ? >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11549
:
24274
|
24275
|
24276
|
24402
|
24403
|
24404
|
24487
|
24503
|
24546
|
24547
|
24548
| 24549