Bugzilla – Attachment 24589 Details for
Bug 11587
IsSuperLibrarian generates warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11587 - IsSuperLibrarian generates warnings
Bug-11587---IsSuperLibrarian-generates-warnings.patch (text/plain), 946 bytes, created by
Mark Tompsett
on 2014-01-21 05:51:20 UTC
(
hide
)
Description:
Bug 11587 - IsSuperLibrarian generates warnings
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-01-21 05:51:20 UTC
Size:
946 bytes
patch
obsolete
>From 166772c8e655afc0c709a819cb1dfe8c6e28bb38 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 21 Jan 2014 00:41:00 -0500 >Subject: [PATCH] Bug 11587 - IsSuperLibrarian generates warnings > >This corrects line 1250 of C4/Context.pm to be: > return ($userenv->{flags}//0) % 2; >And thus avoids an uninitialized value used in the modulus. > >TEST PLAN >--------- >1) Apply the first patch (to update t/Context.t) >2) prove -v t/Context.t >-- This should fail tests 7 and 8 >3) Apply this patch (to fix C4/Context.pm) >4) prove -v t/Context.t >-- All tests should succeed >--- > C4/Context.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Context.pm b/C4/Context.pm >index 3914420..8dc67f2 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -1247,7 +1247,7 @@ sub IsSuperLibrarian { > return 1; > } > >- return $userenv->{flags} % 2; >+ return ($userenv->{flags}//0) % 2; > } > > 1; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11587
:
24587
|
24588
|
24589
|
24666
|
24667
|
24676
|
24677
|
24678