Attachment 24632 Details for Bug 11596 – [SIGNED OFF] Bug 11596: Missing indexing options in koha-conf.xml should be reported

[patch] [SIGNED OFF] Bug 11596: Missing indexing options in koha-conf.xml should be reported

SIGNED-OFF-Bug-11596-Missing-indexing-options-in-k.patch (text/plain), 3.57 KB, created by Mark Tompsett on 2014-01-22 23:51:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2014-01-22 23:51:14 UTC

Size: 3.57 KB

patch

obsolete

>From defee7b2b456e61370fd8e3246e442280d4c6051 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@gmail.com>
>Date: Wed, 22 Jan 2014 11:27:07 -0300
>Subject: [PATCH] [SIGNED OFF] Bug 11596: Missing indexing options in
> koha-conf.xml should be reported
>
>To test:
>- Have a clean master install
>- Verify that koha-conf.xml contains valid entries for:
> zebra_bib_index_mode and
> zebra_auth_index_mode
>- Go to More > About Koha > System information
>=> No "Warnings regarding the system configuration"
>- Apply the patch
>- Go to More > About Koha > System information
>=> No "Warnings regarding the system configuration"
>- Edit your koha-conf.xml file commenting one or both indexing mode
> entries.
>- Go to More > About Koha > System information
>=> You get "XML configuration file" warnings for each commented entry.
>- Sign off :-D
>
>Regards
>To+
>
>Sponsored-by: Universidad Nacional de Cordoba
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>---
> about.pl | 15 +++++++++++++++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 11 +++++++++++
> 2 files changed, 26 insertions(+)
>
>diff --git a/about.pl b/about.pl
>index 6b44ea8..e23e945 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -77,6 +77,20 @@ my $errZebraConnection = C4::Context->Zconn("biblioserver",0)->errcode();
> 
> my $warnIsRootUser = (! $loggedinuser);
> 
>+my @xml_config_warnings;
>+
>+if ( ! defined C4::Context->config('zebra_bib_index_mode') ) {
>+ push @xml_config_warnings, {
>+ error => 'zebra_bib_index_mode_warn'
>+ };
>+}
>+
>+if ( ! defined C4::Context->config('zebra_auth_index_mode') ) {
>+ push @xml_config_warnings, {
>+ error => 'zebra_auth_index_mode_warn'
>+ };
>+}
>+
> $template->param(
> kohaVersion => $kohaVersion,
> osVersion => $osVersion,
>@@ -93,6 +107,7 @@ $template->param(
> warnPrefAnonymousPatron => $warnPrefAnonymousPatron,
> errZebraConnection => $errZebraConnection,
> warnIsRootUser => $warnIsRootUser,
>+ xml_config_warnings => \@xml_config_warnings
> );
> 
> my @components = ();
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index 21db9d3..847047b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -117,6 +117,17 @@
> <tr><th scope="row">Warning </th><td>System preference 'OPACPrivacy' set, but AnonymousPatron preference is set to '0'. Set it to a valid borrower number if you want that this feature works correctly.</td></tr>
> [% END %]
> </table>
>+ [% ELSIF xml_config_warnings.size %]
>+ <table>
>+ <caption>XML configuration file</caption>
>+ [% FOREACH config_entry IN xml_config_warnings %]
>+ [% IF config_entry.error == 'zebra_bib_index_mode_warn' %]
>+ <tr><th scope="row">Warning </th><td>The &lt;zebra_bib_index_mode&gt; entry is missing in your configuration file. It should be set to dom or grs1. It will default to grs1 but this could change in the future.</td></tr>
>+ [% ELSIF config_entry.error == 'zebra_auth_index_mode_warn' %]
>+ <tr><th scope="row">Warning </th><td>The &lt;zebra_auth_index_mode&gt; entry is missing in your configuration file. It should be set to dom or grs1. It will default to dom but this could change in the future.</td></tr>
>+ [% END %]
>+ [% END %]
>+ </table>
> [% ELSE %]
> No warnings
> [% END %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 11596: 24608 | 24632 | 24673 | 24674 | 24679