Attachment 24633 Details for Bug 10944 – Bug 10944 - opac-user and opac-readingrecord had instances of non-https amazon images

[patch] Bug 10944 - opac-user and opac-readingrecord had instances of non-https amazon images

Bug-10944---opac-user-and-opac-readingrecord-had-i.patch (text/plain), 4.57 KB, created by Liz Rea on 2014-01-23 02:12:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2014-01-23 02:12:58 UTC

Size: 4.57 KB

patch

obsolete

>From 61101bdf7ebdfaaa7d289b9168cf4599adb3cf56 Mon Sep 17 00:00:00 2001
>From: Liz Rea <liz@catalyst.net.nz>
>Date: Thu, 23 Jan 2014 15:10:05 +1300
>Subject: [PATCH] Bug 10944 - opac-user and opac-readingrecord had instances
> of non-https amazon images
>
>To test:
>
>* Enable Amazon images in the system preferences
>* Issue a book you know will have images for, verify that without SSL
>1. the images show on the borrower's logged in home page (opac-user) and on the opac-readingrecord
>2. the image source is from an Amazon url that uses http://
>3. the images are the right size, and look ok
>* Do the same using https, verify that with SSL
>1. the images show on the borrower's logged in home page (opac-user) and on the opac-readingrecord
>2. the image source is from an Amazon url that uses https://
>3. the images are the right size, and look ok
>---
> .../bootstrap/en/modules/opac-readingrecord.tt     |    4 +++-
> .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    7 ++++++-
> 2 files changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>index 584e0e3..80e9f1d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
>@@ -72,7 +72,9 @@
>                                         <td>
>                                             [% IF  OPACAmazonCoverImages %]
>                                                 [% IF  issue.normalized_isbn %]
>-                                                    <a href="http://www.amazon.com/gp/reader/[% issue.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link"><img border="0" src="http://images.amazon.com/images/P/[% issue.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /></a>
>+                                                    <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% issue.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link">
>+                                                    [% IF using_https %]<img border="0" src="https://images-na.ssl-images-amazon.com/images/P/[% issue.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" />
>+                                                    [% ELSE %]<img border="0" src="http://images.amazon.com/images/P/[% issue.normalized_isbn %].01.THUMBZZZZ.jpg" alt="" class="item-thumbnail" /> [% END %]                                                    </a>
>                                                 [% ELSE %]
>                                                      <span class="no-image">No cover image available</span>
>                                                 [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index a16dc47..d3377fe 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -130,7 +130,12 @@
> 
>                                                     [% IF ( OPACAmazonCoverImages ) %]
>                                                         [% IF ( ISSUE.normalized_isbn ) %]
>-                                                            <a href="http://www.amazon.com/gp/reader/[% ISSUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com"><img src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /></a>
>+                                                            <a href="http://www.amazon[% AmazonTld %]/gp/reader/[% ISSUE.normalized_isbn %]/ref=sib_dp_pt/002-7879865-0184864#reader-link" title="View at Amazon.com">
>+                                                            [% IF using_https %] 
>+                                                                <img src="https://images-na.ssl-images-amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="" class="item-thumbnail" /></a>
>+                                                            [% ELSE %]
>+                                                                <img border="0" src="http://images.amazon.com/images/P/[% ISSUE.normalized_isbn %].01.THUMBZZZ.jpg" alt="item-thumbnail" />
>+                                                            [% END %] 
>                                                         [% ELSE %]
>                                                             <a href="#"><span class="no-image">No cover image available</span></a>
>                                                         [% END %]
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10944: 21431 | 21839 | 21886 | 22407 | 22409 | 23280 | 23282 | 23283 | 23284 | 23285 | 24633