Bugzilla – Attachment 24681 Details for
Bug 8168
ersatz CSV header in attachment of overdue notices sent to administrator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8168 - Use semicolon as default delimiter
Bug-8168---Use-semicolon-as-default-delimiter.patch (text/plain), 1.56 KB, created by
Mark Tompsett
on 2014-01-24 12:41:09 UTC
(
hide
)
Description:
Bug 8168 - Use semicolon as default delimiter
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2014-01-24 12:41:09 UTC
Size:
1.56 KB
patch
obsolete
>From c1709727dcf53145421c22e28eb81cd51911bfbd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 24 Jan 2014 12:49:39 +0100 >Subject: [PATCH] Bug 8168 - Use semicolon as default delimiter > >installer/data/mysql/sysprefs.sql has semicolon as default. >This fixes both instances to use the same fallback value. >--- > misc/cronjobs/overdue_notices.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index a489f1f..7e83d45 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -359,7 +359,7 @@ binmode( STDOUT, ':encoding(UTF-8)' ); > our $csv; # the Text::CSV_XS object > our $csv_fh; # the filehandle to the CSV file. > if ( defined $csvfilename ) { >- my $sep_char = C4::Context->preference('delimiter') || ','; >+ my $sep_char = C4::Context->preference('delimiter') || ';'; > $sep_char = "\t" if ($sep_char eq 'tabulation'); > $csv = Text::CSV_XS->new( { binary => 1 , sep_char => $sep_char } ); > if ( $csvfilename eq '' ) { >@@ -629,7 +629,7 @@ END_SQL > # Generate the content of the csv with headers > my $content; > if ( defined $csvfilename ) { >- my $delimiter = C4::Context->preference('delimiter') // ';'; >+ my $delimiter = C4::Context->preference('delimiter') || ';'; > $content = join($delimiter, qw(title name surname address1 address2 zipcode city country email itemcount itemsinfo due_date issue_date)) . "\n"; > } > else { >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8168
:
24321
|
24656
|
24665
|
24675
|
24680
|
24681
|
25874
|
25875
|
26413
|
26414